Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 332213005: Revert of Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots. (Closed)

Created:
6 years, 6 months ago by mtklein
Modified:
6 years, 6 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots. (https://codereview.chromium.org/331193004/) Reason for revert: Experiment is over: disabling SSSE3 is a 25-50% perf regression for bitmap scaling on every machine we've got. Original issue's description: > Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots. > > BUG=372232 > > Committed: https://skia.googlesource.com/skia/+/f1e5a04832e4d350f9ebf5d556c6d3897345f883 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=372232 Committed: https://skia.googlesource.com/skia/+/9ccabf7f94500934b4b501492764e6f41449dd27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/opts/opts_check_x86.cpp View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Temporarily limit x86 SIMD to SSE2 only, to see effect on all ...
6 years, 6 months ago (2014-06-16 20:10:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/332213005/1
6 years, 6 months ago (2014-06-16 20:11:17 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 20:11:33 UTC) #3
Message was sent while issue was closed.
Change committed as 9ccabf7f94500934b4b501492764e6f41449dd27

Powered by Google App Engine
This is Rietveld 408576698