Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2488)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java

Issue 332213004: Fix profile comparison re: address lines. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: change test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_profile.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
index 42341b79e1d1da67eb6ad014d288edc7534e9e76..f1712f7dbeef6f99438df2b417a926b0ba354a2b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
@@ -193,14 +193,14 @@ public class PersonalDataManagerTest extends ChromeShellTestBase {
final String streetAddress2 = streetAddress1 + "\n"
+ "Fourth floor\n"
+ "The red bell";
- AutofillProfile profile1 = new AutofillProfile(
+ AutofillProfile profile = new AutofillProfile(
"" /* guid */, "https://www.example.com" /* origin */,
"Monsieur Jean DELHOURME", "Acme Inc.",
streetAddress1,
"Tahiti", "Mahina", "Orofara",
"98709", "CEDEX 98703",
"French Polynesia", "50.71.53", "john@acme.inc", "");
- String profileGuid1 = mHelper.setProfile(profile1);
+ String profileGuid1 = mHelper.setProfile(profile);
assertEquals(1, mHelper.getNumberOfProfiles());
AutofillProfile storedProfile1 = mHelper.getProfile(profileGuid1);
assertEquals("PF", storedProfile1.getCountryCode());
@@ -214,12 +214,10 @@ public class PersonalDataManagerTest extends ChromeShellTestBase {
assertEquals("50.71.53", storedProfile1.getPhoneNumber());
assertEquals("john@acme.inc", storedProfile1.getEmailAddress());
- profile1.setStreetAddress(streetAddress2);
- mHelper.setProfile(profile1);
- assertEquals(1, mHelper.getNumberOfProfiles());
- storedProfile1 = mHelper.getProfile(profileGuid1);
-
- // TODO(estade): http://crbug.com/375545.
- // assertEquals(streetAddress2, storedProfile1.getStreetAddress());
+ profile.setStreetAddress(streetAddress2);
+ String profileGuid2 = mHelper.setProfile(profile);
+ assertEquals(2, mHelper.getNumberOfProfiles());
+ AutofillProfile storedProfile2 = mHelper.getProfile(profileGuid2);
+ assertEquals(streetAddress2, storedProfile2.getStreetAddress());
}
}
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698