Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: Source/devtools/front_end/sdk/BreakpointManager.js

Issue 332203002: Devtools: Update breakpoints only in one specific target on UiSourceCodeMappingChanged (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/BreakpointManager.js
diff --git a/Source/devtools/front_end/sdk/BreakpointManager.js b/Source/devtools/front_end/sdk/BreakpointManager.js
index fb2e32caf6c1f480e2430729433a100cc4d3e24a..e2fc7ed2ecf9e19492051a563e5a93c844530d4d 100644
--- a/Source/devtools/front_end/sdk/BreakpointManager.js
+++ b/Source/devtools/front_end/sdk/BreakpointManager.js
@@ -155,11 +155,12 @@ WebInspector.BreakpointManager.prototype = {
{
var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.target);
var isIdentity = /** @type {boolean} */ (event.data.isIdentity);
+ var target = /** @type {!WebInspector.Target} */ (event.data.target);
if (isIdentity)
return;
var breakpoints = this._breakpointsForPrimaryUISourceCode.get(uiSourceCode) || [];
for (var i = 0; i < breakpoints.length; ++i)
- breakpoints[i]._updateInDebugger();
+ breakpoints[i]._updateInDebuggerForTarget(target);
},
/**
@@ -584,7 +585,9 @@ WebInspector.BreakpointManager.Breakpoint.prototype = {
{
this._removeFakeBreakpointAtPrimaryLocation();
this._fakeBreakpointAtPrimaryLocation();
- this._updateInDebugger();
+ var targetBreakpoints = this._targetBreakpoints.values();
+ for (var i = 0; i < targetBreakpoints.length; ++i)
+ targetBreakpoints[i]._updateInDebugger();
},
/**
@@ -605,11 +608,12 @@ WebInspector.BreakpointManager.Breakpoint.prototype = {
this._breakpointManager._targetManager.unobserveTargets(this);
},
- _updateInDebugger: function()
+ /**
+ * @param {!WebInspector.Target} target
+ */
+ _updateInDebuggerForTarget: function(target)
{
- var targetBreakpoints = this._targetBreakpoints.values();
- for (var i = 0; i < targetBreakpoints.length; ++i)
- targetBreakpoints[i]._updateInDebugger();
+ this._targetBreakpoints.get(target)._updateInDebugger();
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698