Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 332193003: Adding 3 DLLs to the blacklist. (Closed)

Created:
6 years, 6 months ago by krstnmnlsn
Modified:
6 years, 6 months ago
Reviewers:
csharp
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding 3 DLLs to the blacklist. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277791

Patch Set 1 #

Total comments: 2

Patch Set 2 : re-alphabetizing #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
krstnmnlsn
6 years, 6 months ago (2014-06-16 13:55:59 UTC) #1
csharp
https://codereview.chromium.org/332193003/diff/1/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/332193003/diff/1/chrome_elf/blacklist/blacklist.cc#newcode37 chrome_elf/blacklist/blacklist.cc:37: L"activedetect32.dll", // Lenovo One Key Theater. Ah, this list ...
6 years, 6 months ago (2014-06-16 14:09:17 UTC) #2
krstnmnlsn
https://codereview.chromium.org/332193003/diff/1/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/332193003/diff/1/chrome_elf/blacklist/blacklist.cc#newcode37 chrome_elf/blacklist/blacklist.cc:37: L"activedetect32.dll", // Lenovo One Key Theater. On 2014/06/16 14:09:17, ...
6 years, 6 months ago (2014-06-16 14:44:09 UTC) #3
csharp
lgtm, but please don't commit until tomorrow https://codereview.chromium.org/332193003/diff/20001/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/332193003/diff/20001/chrome_elf/blacklist/blacklist.cc#newcode43 chrome_elf/blacklist/blacklist.cc:43: L"windowsapihookdll32.dll", // ...
6 years, 6 months ago (2014-06-16 14:47:17 UTC) #4
krstnmnlsn
https://codereview.chromium.org/332193003/diff/20001/chrome_elf/blacklist/blacklist.cc File chrome_elf/blacklist/blacklist.cc (right): https://codereview.chromium.org/332193003/diff/20001/chrome_elf/blacklist/blacklist.cc#newcode43 chrome_elf/blacklist/blacklist.cc:43: L"windowsapihookdll32.dll", // Lenovo One Key Theater. On 2014/06/16 14:47:17, ...
6 years, 6 months ago (2014-06-16 17:42:22 UTC) #5
krstnmnlsn
The CQ bit was checked by krstnmnlsn@chromium.org
6 years, 6 months ago (2014-06-17 14:51:36 UTC) #6
krstnmnlsn
attempting to commit.
6 years, 6 months ago (2014-06-17 14:51:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/krstnmnlsn@chromium.org/332193003/40001
6 years, 6 months ago (2014-06-17 14:52:58 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:18:51 UTC) #9
Message was sent while issue was closed.
Change committed as 277791

Powered by Google App Engine
This is Rietveld 408576698