Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 332183008: Revert of Forbid creating new wrapper from SetWrapperReferenceTo (Closed)

Created:
6 years, 6 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Revert of Forbid creating new wrapper from SetWrapperReferenceTo (https://codereview.chromium.org/332643003/) Reason for revert: There seems to be an existing bug which hits this callpath. Reverting the change until the bug is fixed. Original issue's description: > Forbid creating new wrapper from SetWrapperReferenceTo > > SetWrapperReferenceTo IDL attribute is a hack to use V8 wrapper reference > to avoid reference cycles in Blink. The |visitDOMWrapper| callback is > used to create a temporary strong reference between the wrappers in GC > prologue. > > Before this patch, |visitDOMWrapper| was allowed to create a new wrapper > if the wrapper for target object didn't exist. However this is dangerous, > as the target object may be already destructed. The target wrapper must > already exist for this reference hack to work correctly. > > This patch forbids creating a new wrapper from |visitDOMWrapper| callback, > and adds an ASSERT that checks that the target object wrapper already > exists. > > BUG=None > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175998 TBR=nbarth@chromium.org,haraken@chromium.org BUG=384459 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/bindings/templates/interface.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kouhei (in TOK)
Created Revert of Forbid creating new wrapper from SetWrapperReferenceTo
6 years, 6 months ago (2014-06-17 03:48:43 UTC) #1
haraken
LGTM. Let's revert it at the moment and fix the underlying bug!
6 years, 6 months ago (2014-06-17 03:49:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/332183008/1
6 years, 6 months ago (2014-06-17 03:50:13 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 04:56:58 UTC) #4
Message was sent while issue was closed.
Change committed as 176281

Powered by Google App Engine
This is Rietveld 408576698