Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: Source/core/inspector/InjectedScriptCanvasModuleSource.js

Issue 332173004: DevTools: [ClosureCompiler] Fix injected script errors on a newer compiler (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/scripts/compile_frontend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InjectedScriptCanvasModuleSource.js
diff --git a/Source/core/inspector/InjectedScriptCanvasModuleSource.js b/Source/core/inspector/InjectedScriptCanvasModuleSource.js
index 1170b4b3315b65fcd135cda13821a7f0403b8305..848ddcadcb8d0c363a3eeca144fcfa88a07b7769 100644
--- a/Source/core/inspector/InjectedScriptCanvasModuleSource.js
+++ b/Source/core/inspector/InjectedScriptCanvasModuleSource.js
@@ -29,6 +29,12 @@
*/
/**
+ * FIXME: ES5 strict mode check is suppressed due to multiple uses of arguments.callee.
+ * @fileoverview
+ * @suppress {es5Strict}
+ */
+
+/**
* @param {InjectedScriptHostClass} InjectedScriptHost
* @param {Window} inspectedWindow
* @param {number} injectedScriptId
@@ -3955,16 +3961,17 @@ WebGLCallFormatter.prototype = {
// Sort to get rid of ambiguity.
for (var value in this._enumValueToNames) {
- var names = this._enumValueToNames[value];
+ var numericValue = Number(value);
+ var names = this._enumValueToNames[numericValue];
if (names.length > 1) {
// Choose one enum name if possible. For example:
// [BLEND_EQUATION, BLEND_EQUATION_RGB] => BLEND_EQUATION
// [COLOR_ATTACHMENT0, COLOR_ATTACHMENT0_WEBGL] => COLOR_ATTACHMENT0
var common = commonSubstring(names);
if (common)
- this._enumValueToNames[value] = [common];
+ this._enumValueToNames[numericValue] = [common];
else
- this._enumValueToNames[value] = names.sort();
+ this._enumValueToNames[numericValue] = names.sort();
}
}
},
« no previous file with comments | « no previous file | Source/devtools/scripts/compile_frontend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698