DevTools: [ClosureCompiler] Fix injected script errors on a newer compiler

Source/core/inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 20 matching lines @@
  * @param {InjectedScriptHost} InjectedScriptHost
  * @param {Window} inspectedWindow
  * @param {number} injectedScriptId
  */
 (function (InjectedScriptHost, inspectedWindow, injectedScriptId) {
 
 /**
  * Protect against Object overwritten by the user code.
  * @suppress {duplicate}
  */
-var Object = /** @type {function(new:Object, *=)} */ ({}.constructor);
+self.Object = /** @type {function(new:Object, *=)} */ ({}.constructor);

[aandrey, 2014/06/16 18:22:07]

how is it supposed to work?

[apavlov, 2014/06/16 19:12:19]

See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.1.1 ("1. Set the
VariableEnvironment to the Global Environment.") and
http://www.ecma-international.org/ecma-262/5.1/#sec-10.5 ("Variables and
functions declared in ECMAScript code evaluated in an execution context are
added as bindings in that VariableEnvironment’s Environment Record"). Thus, at
the top level, "var Foo" is equivalent to "self.Foo" (where "self" is the global
object reference, depending on the context).

[aandrey, 2014/06/16 19:44:47]

This is not top level. Setting "Object" property on window does not lgtm.

[apavlov, 2014/06/17 11:28:14]

Fixed (it used to be top-level when compiling, that's why I got confused)

 
 /**
  * @param {!Array.<T>} array
  * @param {...} var_args
  * @template T
  */
 function push(array, var_args)
 {
     for (var i = 1; i < arguments.length; ++i)
         array[array.length] = arguments[i];
@@ skipping 1647 matching lines @@
      */
     _logEvent: function(event)
     {
         inspectedWindow.console.log(event.type, event);
     }
 }
 
 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl();
 return injectedScript;
 })