DevTools: [ClosureCompiler] Fix injected script errors on a newer compiler

DevTools: [ClosureCompiler] Fix injected script errors on a newer compiler

R=aandrey@chromium.org, yurys@chromium.org, aandrey

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176317

[aandrey, 2014-06-16 18:22:07]

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
Source/core/inspector/InjectedScriptSource.js:41: self.Object = /** @type
{function(new:Object, *=)} */ ({}.constructor);
how is it supposed to work?

[apavlov, 2014-06-16 19:12:19]

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
Source/core/inspector/InjectedScriptSource.js:41: self.Object = /** @type
{function(new:Object, *=)} */ ({}.constructor);
On 2014/06/16 18:22:07, aandrey wrote:
> how is it supposed to work?

See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.1.1 ("1. Set the
VariableEnvironment to the Global Environment.") and
http://www.ecma-international.org/ecma-262/5.1/#sec-10.5 ("Variables and
functions declared in ECMAScript code evaluated in an execution context are
added as bindings in that VariableEnvironment’s Environment Record"). Thus, at
the top level, "var Foo" is equivalent to "self.Foo" (where "self" is the global
object reference, depending on the context).

[aandrey, 2014-06-16 19:44:47]

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
Source/core/inspector/InjectedScriptSource.js:41: self.Object = /** @type
{function(new:Object, *=)} */ ({}.constructor);
On 2014/06/16 19:12:19, apavlov wrote:
> On 2014/06/16 18:22:07, aandrey wrote:
> > how is it supposed to work?
> 
> See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.1.1 ("1. Set the
> VariableEnvironment to the Global Environment.") and
> http://www.ecma-international.org/ecma-262/5.1/#sec-10.5 ("Variables and
> functions declared in ECMAScript code evaluated in an execution context are
> added as bindings in that VariableEnvironment’s Environment Record"). Thus, at
> the top level, "var Foo" is equivalent to "self.Foo" (where "self" is the
global
> object reference, depending on the context).

This is not top level. Setting "Object" property on window does not lgtm.

[apavlov, 2014-06-17 11:28:14]

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/332173004/diff/1/Source/core/inspector/Inject...
Source/core/inspector/InjectedScriptSource.js:41: self.Object = /** @type
{function(new:Object, *=)} */ ({}.constructor);
On 2014/06/16 19:44:47, aandrey wrote:
> On 2014/06/16 19:12:19, apavlov wrote:
> > On 2014/06/16 18:22:07, aandrey wrote:
> > > how is it supposed to work?
> > 
> > See http://www.ecma-international.org/ecma-262/5.1/#sec-10.4.1.1 ("1. Set
the
> > VariableEnvironment to the Global Environment.") and
> > http://www.ecma-international.org/ecma-262/5.1/#sec-10.5 ("Variables and
> > functions declared in ECMAScript code evaluated in an execution context are
> > added as bindings in that VariableEnvironment’s Environment Record"). Thus,
at
> > the top level, "var Foo" is equivalent to "self.Foo" (where "self" is the
> global
> > object reference, depending on the context).
> 
> This is not top level. Setting "Object" property on window does not lgtm.

Fixed (it used to be top-level when compiling, that's why I got confused)

[aandrey, 2014-06-17 11:38:34]

lgtm

https://codereview.chromium.org/332173004/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InjectedScriptCanvasModuleSource.js (right):

https://codereview.chromium.org/332173004/diff/20001/Source/core/inspector/In...
Source/core/inspector/InjectedScriptCanvasModuleSource.js:33: * @suppress
{es5Strict}
a comment of FIXME why suppressing

https://codereview.chromium.org/332173004/diff/20001/Source/devtools/scripts/...
File Source/devtools/scripts/compile_frontend.py (right):

https://codereview.chromium.org/332173004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/compile_frontend.py:95: invalid_type_designator_regex =
re.compile(r"@(?:" + type_checked_jsdoc_tags_or + r")\s*.*(?<![{: ])([?!])=?\}")
hard to review

https://codereview.chromium.org/332173004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/compile_frontend.py:295: if has_object_override:
just remove the flag?

[apavlov, 2014-06-17 11:54:04]

https://codereview.chromium.org/332173004/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InjectedScriptCanvasModuleSource.js (right):

https://codereview.chromium.org/332173004/diff/20001/Source/core/inspector/In...
Source/core/inspector/InjectedScriptCanvasModuleSource.js:33: * @suppress
{es5Strict}
On 2014/06/17 11:38:33, aandrey wrote:
> a comment of FIXME why suppressing

Done.

https://codereview.chromium.org/332173004/diff/20001/Source/devtools/scripts/...
File Source/devtools/scripts/compile_frontend.py (right):

https://codereview.chromium.org/332173004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/compile_frontend.py:295: if has_object_override:
On 2014/06/17 11:38:33, aandrey wrote:
> just remove the flag?

Done.

[yurys, 2014-06-17 12:12:27]

lgtm

[apavlov, 2014-06-17 12:14:30]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-06-17 12:15:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/332173004/40001

[apavlov, 2014-06-17 13:44:20]

The CQ bit was unchecked by apavlov@chromium.org

[apavlov, 2014-06-17 13:44:21]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-06-17 13:44:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/332173004/40001

[apavlov, 2014-06-17 14:41:43]

Committed patchset #3 manually as r176317 (presubmit successful).