Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332163006: Manage settings window icon for multi profile (Closed)

Created:
6 years, 6 months ago by stevenjb
Modified:
6 years, 6 months ago
CC:
chromium-reviews, sadrul, tfarina, yoshiki+watch_chromium.org, rginda+watch_chromium.org, kalyank, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Manage settings window icon for multi profile Includes some minor refactoring: merges launcher_item_util.cc into ash:shelf_util.cc BUG=385161 R=ben@chromium.org, skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278629

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Rebase, Add TODO for test #

Patch Set 4 : . #

Patch Set 5 : Fix browsertest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -43 lines) Patch
M ash/shelf/shelf_util.h View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M ash/shelf/shelf_util.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
D chrome/browser/ui/ash/launcher/launcher_item_util.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/ash/launcher/launcher_item_util.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/settings_window_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/settings_window_manager.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
stevenjb
6 years, 6 months ago (2014-06-17 00:29:41 UTC) #1
Mr4D (OOO till 08-26)
Since you are adding and removing items from the shelf - could you add a ...
6 years, 6 months ago (2014-06-17 16:01:10 UTC) #2
stevenjb
PTAL I added a TODO item for the tests. Based on our discussions there isn't ...
6 years, 6 months ago (2014-06-18 19:54:48 UTC) #3
Mr4D (OOO till 08-26)
lgtm
6 years, 6 months ago (2014-06-18 20:43:21 UTC) #4
stevenjb
+ben@chromium.org for c/b/ui owner (settings related) + FYI
6 years, 6 months ago (2014-06-18 22:07:05 UTC) #5
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-19 02:56:43 UTC) #6
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 6 months ago (2014-06-19 02:59:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/332163006/60001
6 years, 6 months ago (2014-06-19 03:00:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 10:27:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/39421)
6 years, 6 months ago (2014-06-19 10:27:06 UTC) #10
stevenjb
6 years, 6 months ago (2014-06-20 06:20:06 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 manually as r278629 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698