Source/modules/geolocation/testing/GeolocationClientMock.h - Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/testing/GeolocationClientMock.h

Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make GeolocationClientMock also use a persistent heap hash set to its controllers Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/geolocation/GeolocationInspectorAgent.h ('K') | « Source/modules/geolocation/GeolocationInspectorAgent.cpp ('k') | Source/modules/geolocation/testing/GeolocationClientMock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/testing/GeolocationClientMock.h

diff --git a/Source/modules/geolocation/testing/GeolocationClientMock.h b/Source/modules/geolocation/testing/GeolocationClientMock.h

index 3bb6a45643066ec915ad145230dd2f319f09419c..3d7b0fd3ba6238c3d40632871dc5ccc1fe59e5cd 100644

--- a/Source/modules/geolocation/testing/GeolocationClientMock.h

+++ b/Source/modules/geolocation/testing/GeolocationClientMock.h

@@ -74,7 +74,8 @@ private:

void clearError();

- HashSet<GeolocationController*> m_controllers;

+ typedef HeapHashSet<RawPtrWillBeMember<GeolocationController> > GeolocationControllers;

+ PersistentHeapHashSet<RawPtrWillBeMember<GeolocationController> > m_controllers;

Persistent<GeolocationPosition> m_lastPosition;

bool m_hasError;

String m_errorMessage;

@@ -89,8 +90,8 @@ private:

};

PermissionState m_permissionState;

- typedef PersistentHeapHashSet<Member<Geolocation> > GeolocationSet;

- GeolocationSet m_pendingPermissions;

+ typedef HeapHashSet<Member<Geolocation> > GeolocationSet;

+ PersistentHeapHashSet<Member<Geolocation> > m_pendingPermissions;

};

}