Source/modules/geolocation/GeolocationInspectorAgent.h - Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/GeolocationInspectorAgent.h

Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make GeolocationClientMock also use a persistent heap hash set to its controllers Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/geolocation/GeolocationInspectorAgent.h

diff --git a/Source/modules/geolocation/GeolocationInspectorAgent.h b/Source/modules/geolocation/GeolocationInspectorAgent.h

index e3c526059da3e03cc7d27a8816fbaec66e4f4176..2a950444bf585570063398ee7199f53abc6ad5d9 100644

--- a/Source/modules/geolocation/GeolocationInspectorAgent.h

+++ b/Source/modules/geolocation/GeolocationInspectorAgent.h

@@ -61,7 +61,8 @@ public:

private:

GeolocationInspectorAgent();

- WTF::HashSet<GeolocationController*> m_controllers;

+ typedef HeapHashSet<RawPtrWillBeMember<GeolocationController> > GeolocationControllers;

+ PersistentHeapHashSet<RawPtrWillBeMember<GeolocationController> > m_controllers;

zerny-chromium 2014/06/16 09:50:18 Should we use WillBe(Persistent)HeapHashSet for th

sof 2014/06/16 10:39:06 Yes, thanks. Added WillBe prefixes (in both places

bool m_geolocationOverridden;

Persistent<GeolocationPosition> m_geolocationPosition;

Persistent<GeolocationPosition> m_platformGeolocationPosition;

« no previous file with comments | « no previous file | Source/modules/geolocation/GeolocationInspectorAgent.cpp » ('j') | no next file with comments »