Issue 332123002: GN: Enable blink platform heap targets, put all tests behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332123002: GN: Enable blink platform heap targets, put all tests behind flag (Closed)

Created:
6 years, 6 months ago by jamesr

Modified:
6 years, 6 months ago

Reviewers:
brettw

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

GN: Enable blink platform heap targets, put all tests behind flag This puts the blink heap asm targets in the GN build set and enables both blink platform test targets behind a single flag. They compile, link and run successfully on mac but (probably) don't link yet on linux due to ffmpeg deps. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176174

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -20 lines)			Patch
	M	Source/platform/BUILD.gn	View		9 chunks	+9 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/332123002/1

6 years, 6 months ago (2014-06-16 04:52:10 UTC) #4

Message was sent while issue was closed.

Change committed as 176174

Expand Messages | Collapse Messages