ChromeDriver has pre-installed APK's, thus should not wipe during provisioning.

ChromeDriver has pre-installed APK's, thus should not wipe during provisioning.

BUG=383106
TBR=craigdh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277628

[klundberg, 2014-06-16 15:43:09]

lgtm

Thanks, Armand!

[dnj, 2014-06-16 15:45:01]

lgtm

[jbudorick, 2014-06-16 18:08:04]

lgtm

[navabi, 2014-06-16 18:44:12]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2014-06-16 18:46:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/navabi@google.com/332093003/1

[commit-bot: I haz the power, 2014-06-16 18:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 18:46:11]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[navabi, 2014-06-16 19:12:20]

need commiter LGTM

[zty, 2014-06-16 19:18:00]

lgtm

[navabi, 2014-06-16 19:20:44]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2014-06-16 19:21:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/navabi@google.com/332093003/1

[commit-bot: I haz the power, 2014-06-16 19:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 19:21:36]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[navabi, 2014-06-16 19:22:25]

The CQ bit was checked by navabi@google.com

[commit-bot: I haz the power, 2014-06-16 19:24:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/navabi@google.com/332093003/1

[commit-bot: I haz the power, 2014-06-17 02:40:16]

Change committed as 277628

[M-A Ruel, 2014-07-09 15:35:16]

On 2014/06/17 02:40:16, I haz the power (commit-bot) wrote:
> Change committed as 277628

I now get this:
$ git cl upl
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from ~/.codereview_upload_cookies
Running presubmit upload checks ...

** Presubmit Warnings **
src/build/android/buildbot/tests/bb_run_bot_test.py (0.45s) failed
Error running the bot script with id="try-tests-rel" Traceback (most recent call
last):
  File "build/android/buildbot/bb_device_steps.py", line 698, in <module>
    sys.exit(main(sys.argv))
  File "build/android/buildbot/bb_device_steps.py", line 694, in main
    MainTestWrapper(options)
  File "build/android/buildbot/bb_device_steps.py", line 603, in MainTestWrapper
    bb_utils.RunSteps(options.test_filter, GetTestStepCmds(), options)
  File "src/build/android/buildbot/bb_utils.py", line 100, in RunSteps
    cmd(options)
  File "build/android/buildbot/bb_device_steps.py", line 152, in
RunTelemetryPerfUnitTests
    devices = android_commands.GetAttachedDevices()
  File "src/build/android/buildbot/../pylib/android_commands.py", line 158, in
GetAttachedDevices
    'devices'])
  File "src/build/android/buildbot/../pylib/cmd_helper.py", line 67, in
GetCmdOutput
    (_, output) = GetCmdStatusAndOutput(args, cwd, shell)
  File "src/build/android/buildbot/../pylib/cmd_helper.py", line 99, in
GetCmdStatusAndOutput
    shell=shell, cwd=cwd)
  File "src/build/android/buildbot/../pylib/cmd_helper.py", line 27, in Popen
    preexec_fn=lambda: signal.signal(signal.SIGPIPE, signal.SIG_DFL))
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Error running the bot script with id="main-tests-rel" Traceback (most recent
call last):
  File "build/android/buildbot/bb_device_steps.py", line 698, in <module>
    sys.exit(main(sys.argv))
  File "build/android/buildbot/bb_device_steps.py", line 694, in main
    MainTestWrapper(options)
  File "build/android/buildbot/bb_device_steps.py", line 603, in MainTestWrapper
    bb_utils.RunSteps(options.test_filter, GetTestStepCmds(), options)
  File "src/build/android/buildbot/bb_utils.py", line 100, in RunSteps
    cmd(options)
  File "build/android/buildbot/bb_device_steps.py", line 152, in
RunTelemetryPerfUnitTests
    devices = android_commands.GetAttachedDevices()
  File "src/build/android/buildbot/../pylib/android_commands.py", line 158, in
GetAttachedDevices
    'devices'])
  File "src/build/android/buildbot/../pylib/cmd_helper.py", line 67, in
GetCmdOutput
    (_, output) = GetCmdStatusAndOutput(args, cwd, shell)
  File "src/build/android/buildbot/../pylib/cmd_helper.py", line 99, in
GetCmdStatusAndOutput
    shell=shell, cwd=cwd)
  File "src/build/android/buildbot/../pylib/cmd_helper.py", line 27, in Popen
    preexec_fn=lambda: signal.signal(signal.SIGPIPE, signal.SIG_DFL))
  File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

It's because I don't have adb in the path. Could either an error message be
created or the test fixed?

[M-A Ruel, 2014-07-09 15:35:56]

On 2014/07/09 15:35:16, M-A Ruel wrote:
> On 2014/06/17 02:40:16, I haz the power (commit-bot) wrote:
> > Change committed as 277628
> 
> I now get this:
> $ git cl upl
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Loaded authentication cookies from ~/.codereview_upload_cookies
> Running presubmit upload checks ...
> 
> ** Presubmit Warnings **
> src/build/android/buildbot/tests/bb_run_bot_test.py (0.45s) failed
> Error running the bot script with id="try-tests-rel" Traceback (most recent
call
> last):
>   File "build/android/buildbot/bb_device_steps.py", line 698, in <module>
>     sys.exit(main(sys.argv))
>   File "build/android/buildbot/bb_device_steps.py", line 694, in main
>     MainTestWrapper(options)
>   File "build/android/buildbot/bb_device_steps.py", line 603, in
MainTestWrapper
>     bb_utils.RunSteps(options.test_filter, GetTestStepCmds(), options)
>   File "src/build/android/buildbot/bb_utils.py", line 100, in RunSteps
>     cmd(options)
>   File "build/android/buildbot/bb_device_steps.py", line 152, in
> RunTelemetryPerfUnitTests
>     devices = android_commands.GetAttachedDevices()
>   File "src/build/android/buildbot/../pylib/android_commands.py", line 158, in
> GetAttachedDevices
>     'devices'])
>   File "src/build/android/buildbot/../pylib/cmd_helper.py", line 67, in
> GetCmdOutput
>     (_, output) = GetCmdStatusAndOutput(args, cwd, shell)
>   File "src/build/android/buildbot/../pylib/cmd_helper.py", line 99, in
> GetCmdStatusAndOutput
>     shell=shell, cwd=cwd)
>   File "src/build/android/buildbot/../pylib/cmd_helper.py", line 27, in Popen
>     preexec_fn=lambda: signal.signal(signal.SIGPIPE, signal.SIG_DFL))
>   File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
>     errread, errwrite)
>   File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
>     raise child_exception
> OSError: [Errno 2] No such file or directory
> 
> Error running the bot script with id="main-tests-rel" Traceback (most recent
> call last):
>   File "build/android/buildbot/bb_device_steps.py", line 698, in <module>
>     sys.exit(main(sys.argv))
>   File "build/android/buildbot/bb_device_steps.py", line 694, in main
>     MainTestWrapper(options)
>   File "build/android/buildbot/bb_device_steps.py", line 603, in
MainTestWrapper
>     bb_utils.RunSteps(options.test_filter, GetTestStepCmds(), options)
>   File "src/build/android/buildbot/bb_utils.py", line 100, in RunSteps
>     cmd(options)
>   File "build/android/buildbot/bb_device_steps.py", line 152, in
> RunTelemetryPerfUnitTests
>     devices = android_commands.GetAttachedDevices()
>   File "src/build/android/buildbot/../pylib/android_commands.py", line 158, in
> GetAttachedDevices
>     'devices'])
>   File "src/build/android/buildbot/../pylib/cmd_helper.py", line 67, in
> GetCmdOutput
>     (_, output) = GetCmdStatusAndOutput(args, cwd, shell)
>   File "src/build/android/buildbot/../pylib/cmd_helper.py", line 99, in
> GetCmdStatusAndOutput
>     shell=shell, cwd=cwd)
>   File "src/build/android/buildbot/../pylib/cmd_helper.py", line 27, in Popen
>     preexec_fn=lambda: signal.signal(signal.SIGPIPE, signal.SIG_DFL))
>   File "/usr/lib/python2.7/subprocess.py", line 679, in __init__
>     errread, errwrite)
>   File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child
>     raise child_exception
> OSError: [Errno 2] No such file or directory
> 
> It's because I don't have adb in the path. Could either an error message be
> created or the test fixed?

To clarify, I don't think it's this CL particularly but it's relatively recent
and in this area.