chrome/browser/safe_browsing/preference_validation_delegate.cc - Issue 332053005: Unit test for NULL values in preference validation delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/preference_validation_delegate.cc

Issue 332053005: Unit test for NULL values in preference validation delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new test for clarity Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/preference_validation_delegate.cc

diff --git a/chrome/browser/safe_browsing/preference_validation_delegate.cc b/chrome/browser/safe_browsing/preference_validation_delegate.cc

index 5d0dfb523ab1760bf36aebd795867c6df8f28afa..f92ae9dd2239aaac160f78a81a84c02c50adb88b 100644

--- a/chrome/browser/safe_browsing/preference_validation_delegate.cc

+++ b/chrome/browser/safe_browsing/preference_validation_delegate.cc

@@ -72,7 +72,7 @@ void PreferenceValidationDelegate::OnAtomicPreferenceValidation(

void PreferenceValidationDelegate::OnSplitPreferenceValidation(

const std::string& pref_path,

- const base::DictionaryValue* dict_value,

+ const base::DictionaryValue* /* dict_value */,

const std::vector<std::string>& invalid_keys,

PrefHashStoreTransaction::ValueState value_state,

TrackedPreferenceHelper::ResetAction /* reset_action */) {