Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 332053004: Parser: Refactor strict mode checks for functions (Closed)

Created:
6 years, 6 months ago by aperez
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Parser: Refactor strict mode checks for functions Moves the strict mode checks and error reporting for the function and parameter names into a separate CheckStrictFunctionNameAndParameters() function in ParserBase. Parsing of arrow functions will then use this new function instead of duplicating the error code. BUG= R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 chunk +8 lines, -27 lines 0 comments Download
M src/preparser.h View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aperez
It would be nice to have this change applied so arrow function parsing could use ...
6 years, 6 months ago (2014-06-14 20:44:22 UTC) #1
marja
lgtm. I can also land this, but I'd like my other Parser changes to stabilize ...
6 years, 6 months ago (2014-06-16 07:04:14 UTC) #2
aperez
On 2014/06/16 07:04:14, marja wrote: > lgtm. I can also land this, but I'd like ...
6 years, 6 months ago (2014-06-16 09:50:08 UTC) #3
marja
6 years, 6 months ago (2014-06-20 09:45:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21896 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698