Issue 332018: Initialize WebContextMenuData::mediaFlags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332018: Initialize WebContextMenuData::mediaFlags. (Closed)

Created:
11 years, 2 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Initialize WebContextMenuData::mediaFlags. Before we were having completely random results right-clicking media elements. Fun, but not user friendly. BUG=25358 TEST=right click on media elements -- observe consistent/expected behaviour Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29976

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/api/src/WebContextMenuClientImpl.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

11 years, 2 months ago (2009-10-24 00:36:44 UTC) #4

too late!  already committed!!  mwahahh!

On Fri, Oct 23, 2009 at 5:32 PM, <ajwong@chromium.org> wrote:

> and by nice, I meant LGTM. :-/
>
>
> http://codereview.chromium.org/332018
>

Expand Messages | Collapse Messages