Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 332018: Initialize WebContextMenuData::mediaFlags. (Closed)

Created:
11 years, 2 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Initialize WebContextMenuData::mediaFlags. Before we were having completely random results right-clicking media elements. Fun, but not user friendly. BUG=25358 TEST=right click on media elements -- observe consistent/expected behaviour Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webkit/api/src/WebContextMenuClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
haha
11 years, 2 months ago (2009-10-24 00:15:01 UTC) #1
awong
Nice.
11 years, 2 months ago (2009-10-24 00:17:33 UTC) #2
awong
and by nice, I meant LGTM. :-/
11 years, 2 months ago (2009-10-24 00:32:51 UTC) #3
scherkus (not reviewing)
11 years, 2 months ago (2009-10-24 00:36:44 UTC) #4
too late!  already committed!!  mwahahh!

On Fri, Oct 23, 2009 at 5:32 PM, <ajwong@chromium.org> wrote:

> and by nice, I meant LGTM. :-/
>
>
> http://codereview.chromium.org/332018
>

Powered by Google App Engine
This is Rietveld 408576698