Add a regression test for the PluginChannel::CleanUp. My earlier speculative...

Add a regression test for the PluginChannel::CleanUp.  My earlier speculative fix was correct.

I tracked this down to my earlier change to not leak NPObjects on channel shutdown (which now happens a lot more often because of sudden termination for tab close).  Since we now call an NPObject's deallocate function, it's possible that it leads to an NPObjectProxy being deleted, in which case we would delete an object in the listener's array while we're looping across it.

BUG=25439
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29982

[iyengar, 2009-10-23 23:48:42]

Hi John
I was unable to review TestObject.h/.cc due to broken link errors. Could you
try uploading this CL one more time and
check if these links work?

Thanks
Ananta

On Fri, Oct 23, 2009 at 12:30 PM, <jam@chromium.org> wrote:

> Reviewers: ananta,
>
> Description:
> Add a regression test for the PluginChannel::CleanUp.  My earlier
> speculative
> fix was correct.
>
> I tracked this down to my earlier change to not leak NPObjects on channel
> shutdown (which now happens a lot more often because of sudden termination
> for
> tab close).  Since we now call an NPObject's deallocate function, it's
> possible
> that it leads to an NPObjectProxy being deleted, in which case we would
> delete
> an object in the listener's array while we're looping across it.
>
> BUG=25439
>
> Please review this at http://codereview.chromium.org/332013
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  A     chrome/test/data/npapi/npobject_released_on_destruction.html
>  M     chrome/test/ui/npapi_uitest.cc
>  M     webkit/tools/npapi_layout_test_plugin/TestObject.h
>  M     webkit/tools/npapi_layout_test_plugin/TestObject.cpp
>
>
>

[jam, 2009-10-24 00:19:48]

Strange, I just re-uploaded.

[ananta, 2009-10-24 00:33:59]

LGTM