Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 3320011: [noupstream] Instrument for thread suspension. (Closed)

Created:
8 years, 3 months ago by eaeltsin
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[noupstream] Instrument for thread suspension. When given command line flag -finstrument-for-thread-suspension, generate instrumentation calls for function entry and back edges. Instrumentation call now looks like: __nacl_suspend_thread_if_needed (); BUG=http://code.google.com/p/nativeclient/issues/detail?id=826 TEST=

Patch Set 1 #

Patch Set 2 : +bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M gcc/gcc/config/nacl.opt View 1 chunk +3 lines, -0 lines 0 comments Download
M gcc/gcc/tree-profile.c View 2 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eaeltsin
8 years, 3 months ago (2010-09-06 16:12:43 UTC) #1
khimg
Have you tried to compile tests, spec cpu2000, etc with this?
8 years, 3 months ago (2010-09-06 16:15:51 UTC) #2
Mark Seaborn
Could you create an issue to track this, so that there is somewhere to record ...
8 years, 3 months ago (2010-09-06 16:28:11 UTC) #3
khimg
LGTM, except for the BUG...
8 years, 3 months ago (2010-09-06 17:43:29 UTC) #4
eaeltsin
There is a bug created by Brad, added link to it: http://code.google.com/p/nativeclient/issues/detail?id=826 On 2010/09/06 16:28:11, ...
8 years, 3 months ago (2010-09-06 20:31:41 UTC) #5
eaeltsin
Run spec cpu2000 with -finstrument-for-thread-suspension, all passed. On 2010/09/06 16:15:51, khimg wrote: > Have you ...
8 years, 3 months ago (2010-09-06 20:39:01 UTC) #6
pasko-google - do not use
8 years, 3 months ago (2010-09-07 10:23:12 UTC) #7
LGTM

given that it's noupstream, that was easy

Powered by Google App Engine
This is Rietveld 408576698