MacViews: Run native Cocoa context menus to support Services.

ui/views/controls/menu/menu_runner_impl_adapter.h

Index: ui/views/controls/menu/menu_runner_impl_adapter.h
diff --git a/ui/views/controls/menu/menu_runner_impl_adapter.h b/ui/views/controls/menu/menu_runner_impl_adapter.h
new file mode 100644
index 0000000000000000000000000000000000000000..6f407141ca5e6c2133db5e4a0faffab0bc7d3b38
--- /dev/null
+++ b/ui/views/controls/menu/menu_runner_impl_adapter.h
@@ -0,0 +1,41 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_ADAPTER_H_
+#define UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_ADAPTER_H_
+
+#include "ui/views/controls/menu/menu_runner_impl_interface.h"
+
+namespace views {
+namespace internal {
+
+class MenuRunnerImpl;
+
+// Given a MenuModel, adapts MenuRunnerImpl which expects a MenuItemView.
+class MenuRunnerImplAdapter : public MenuRunnerImplInterface {

[sky, 2014/07/14 21:02:22]

This class confused me a bit. Is there a reason not to combine with
MenuRunnerImpl?

[Andre, 2014/07/14 22:59:42]

I created this mainly so that I don't have create a second MenuRunnerImpl
constructor
that takes a MenuModel, and then having to factor out the initializations of its
8 members
to a separate private init. I can't use delegating constructor because
menu_model_adapter_
would need to be initialized first. But I can do that if you prefer.

[sky, 2014/07/15 04:33:44]

How about a helper class that both use then?

+ public:
+  explicit MenuRunnerImplAdapter(ui::MenuModel* menu_model);
+
+  virtual MenuItemView* GetMenu() const OVERRIDE;

[sky, 2014/07/14 21:02:22]

Prefix wit // MenuRunnerImplyInterface:
(or something similar).

[Andre, 2014/07/14 22:59:42]

Done.

+  virtual bool IsRunning() const OVERRIDE;
+  virtual void Release() OVERRIDE;
+  virtual MenuRunner::RunResult RunMenuAt(Widget* parent,
+                                          MenuButton* button,
+                                          const gfx::Rect& bounds,
+                                          MenuAnchorPosition anchor,
+                                          int32 types) OVERRIDE;
+  virtual void Cancel() OVERRIDE;
+  virtual base::TimeDelta GetClosingEventTime() const OVERRIDE;
+
+ private:
+  virtual ~MenuRunnerImplAdapter();
+
+  scoped_ptr<MenuModelAdapter> menu_model_adapter_;
+  MenuRunnerImpl* impl_;
+};

[sky, 2014/07/14 21:02:22]

DISALLOW_...

[Andre, 2014/07/14 22:59:42]

Done.

+
+}  // namespace internal
+}  // namespace views
+
+#endif  // UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_ADAPTER_H_