chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 331993009: MacViews: Run native Cocoa context menus to support Services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 331993009: MacViews: Run native Cocoa context menus to support Services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add VIEWS_EXPORT for unit test access Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permission_selector_view.cc ('k') | content/shell/browser/shell_views.cc » ('j') | ui/views/controls/menu/menu_runner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index 884dc18badbd54fb11517e1f030fdfe1bd9e1a30..744f635147947171d3ca956c0ec71a20fdde7b55 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -111,7 +111,8 @@ void PermissionCombobox::GetAccessibleState(ui::AXViewState* state) {

void PermissionCombobox::OnMenuButtonClicked(View* source,

const gfx::Point& point) {

- menu_runner_.reset(new views::MenuRunner(model_.get()));

+ menu_runner_.reset(

+ new views::MenuRunner(model_.get(), views::MenuRunner::HAS_MNEMONICS));

gfx::Point p(point);

p.Offset(-source->width(), 0);

@@ -119,8 +120,7 @@ void PermissionCombobox::OnMenuButtonClicked(View* source,

this,

gfx::Rect(p, gfx::Size()),

views::MENU_ANCHOR_TOPLEFT,

- ui::MENU_SOURCE_NONE,

- views::MenuRunner::HAS_MNEMONICS) ==

+ ui::MENU_SOURCE_NONE) ==

views::MenuRunner::MENU_DELETED) {

return;

}