chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc - Issue 331993009: MacViews: Run native Cocoa context menus to support Services.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc

Issue 331993009: MacViews: Run native Cocoa context menus to support Services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add VIEWS_EXPORT for unit test access Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | ui/views/controls/menu/menu_runner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc

index 2e0331f3498c756b2e362845236e484b68e21054..04707b8a253d7c6001ff2a0220bce55492dae1e7 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc

@@ -37,7 +37,7 @@ class BookmarkMenuDelegateTest : public BrowserWithTestWindowTest {

if (bookmark_menu_delegate_.get()) {

// Since we never show the menu we need to pass the MenuItemView to

// MenuRunner so that the MenuItemView is destroyed.

- views::MenuRunner menu_runner(bookmark_menu_delegate_->menu());

+ views::MenuRunner menu_runner(bookmark_menu_delegate_->menu(), 0);

bookmark_menu_delegate_.reset();

}

BrowserWithTestWindowTest::TearDown();

@@ -47,7 +47,7 @@ class BookmarkMenuDelegateTest : public BrowserWithTestWindowTest {

void NewDelegate(int min_menu_id, int max_menu_id) {

// Destroy current menu if available, see comments in TearDown().

if (bookmark_menu_delegate_.get())

- views::MenuRunner menu_runner(bookmark_menu_delegate_->menu());

+ views::MenuRunner menu_runner(bookmark_menu_delegate_->menu(), 0);

bookmark_menu_delegate_.reset(

new BookmarkMenuDelegate(browser(), NULL, NULL,