MacViews: Run native Cocoa context menus to support Services.

ui/views/controls/menu/menu_runner.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_
 #define UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 16 matching lines @@
 namespace views {
 
 class MenuButton;
 class MenuItemView;
 class MenuModelAdapter;
 class MenuRunnerHandler;
 class Widget;
 
 namespace internal {
 class DisplayChangeListener;
-class MenuRunnerImpl;
+class MenuRunnerImplInterface;
 }
 
 namespace test {
 class MenuRunnerTestAPI;
 }
 
 // MenuRunner is responsible for showing (running) the menu and additionally
 // owning the MenuItemView. RunMenuAt() runs a nested message loop. It is safe
 // to delete MenuRunner at any point, but MenuRunner internally only deletes the
 // MenuItemView *after* the nested message loop completes. If MenuRunner is
@@ skipping 78 matching lines @@
 
   // Returns the time from the event which closed the menu - or 0.
   base::TimeDelta closing_event_time() const;
 
  private:
   friend class test::MenuRunnerTestAPI;
 
   // Sets an implementation of RunMenuAt. This is intended to be used at test.
   void SetRunnerHandler(scoped_ptr<MenuRunnerHandler> runner_handler);
 
+  internal::MenuRunnerImplInterface* CreateImpl(int32 types);
+  internal::MenuRunnerImplInterface* CreateNativeImpl();

[tapted, 2014/06/24 23:28:08]

Id probably try to have

MenuRunnerImplInterface::CreateForType(ui::MenuModel* model, int32 type); which
can return NULL

and have (in menu_runner_impl.cc)

#if !defined(OS_MACOSX)
MenuRunnerImplInterface* MenuRunnerImplInterface::CreateForType(ui::MenuModel*
model, int32 type) {
  return NULL;
}
#endif

then (somewhere)

.. (..) {
  if (menu_model_)
    holder_ = MenuRunnerImplInterface::CreateForType(menu_model_, type);

  if (!holder_) {
    /* create adapter */
    holder_ = new MenuRunnerImplInterface(things);
  }
}


but I'll have a deeper look to see if this will work.

(ideally holder_ will always be non-null)

+
+  ui::MenuModel* menu_model_;  // Weak. Owned by our owner.
+                               // NULL if constructed with a MenuView.
   scoped_ptr<MenuModelAdapter> menu_model_adapter_;
+  MenuItemView* menu_view_;  // Weak. Owned by holder_. Can be NULL.
 
-  internal::MenuRunnerImpl* holder_;
+  // We own this. No scoped_ptr because it is destroyed by calling Release().
+  internal::MenuRunnerImplInterface* holder_;
 
   // An implementation of RunMenuAt. This is usually NULL and ignored. If this
   // is not NULL, this implementation will be used.
   scoped_ptr<MenuRunnerHandler> runner_handler_;
 
   scoped_ptr<internal::DisplayChangeListener> display_change_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuRunner);
 };
 
 namespace internal {
 
 // DisplayChangeListener is intended to listen for changes in the display size
 // and cancel the menu. DisplayChangeListener is created when the menu is
 // shown.
 class DisplayChangeListener {
  public:
   virtual ~DisplayChangeListener() {}
 
   // Creates the platform specified DisplayChangeListener, or NULL if there
   // isn't one. Caller owns the returned value.
   static DisplayChangeListener* Create(Widget* parent,
                                        MenuRunner* runner);
 
  protected:
   DisplayChangeListener() {}
 };
 
-}
+}  // namespace internal
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_H_