MacViews: Run native Cocoa context menus to support Services.

chrome/browser/ui/views/toolbar/browser_action_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/browser_action_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/extension_action.h"
@@ skipping 170 matching lines @@
     const gfx::Point& point,
     ui::MenuSourceType source_type) {
   if (!extension()->ShowConfigureContextMenus())
     return;
 
   SetButtonPushed();
 
   // Reconstructs the menu every time because the menu's contents are dynamic.
   scoped_refptr<ExtensionContextMenuModel> context_menu_contents(
       new ExtensionContextMenuModel(extension(), browser_, delegate_));
-  menu_runner_.reset(new views::MenuRunner(context_menu_contents.get()));
-
-  context_menu_ = menu_runner_->GetMenu();
   gfx::Point screen_loc;
   views::View::ConvertPointToScreen(this, &screen_loc);
 
   views::Widget* parent = NULL;
   int run_types = views::MenuRunner::HAS_MNEMONICS |
                   views::MenuRunner::CONTEXT_MENU;
   if (delegate_->ShownInsideMenu()) {
     run_types |= views::MenuRunner::IS_NESTED;
     // RunMenuAt expects a nested menu to be parented by the same widget as the
     // already visible menu, in this case the Chrome menu.
     parent = BrowserView::GetBrowserViewForBrowser(browser_)->toolbar()
                                                             ->app_menu()
                                                             ->GetWidget();
   } else {
     parent = GetWidget();
   }
 
+  menu_runner_.reset(
+      new views::MenuRunner(context_menu_contents.get(), run_types));
+  context_menu_ = menu_runner_->GetMenu();
+
   if (menu_runner_->RunMenuAt(parent,
                               NULL,
                               gfx::Rect(screen_loc, size()),
                               views::MENU_ANCHOR_TOPLEFT,
-                              source_type,
-                              run_types) ==
+                              source_type) ==
       views::MenuRunner::MENU_DELETED) {
     return;
   }
 
   menu_runner_.reset();
   SetButtonNotPushed();
   context_menu_ = NULL;
 }
 
 void BrowserActionButton::UpdateState() {
@@ skipping 221 matching lines @@
   extensions::Command browser_action_command;
   if (!only_if_active || !command_service->GetBrowserActionCommand(
           extension_->id(),
           extensions::CommandService::ACTIVE_ONLY,
           &browser_action_command,
           NULL)) {
     GetFocusManager()->UnregisterAccelerator(*keybinding_.get(), this);
     keybinding_.reset(NULL);
   }
 }