Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 331983002: [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault (https://coderevie… (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai, awong
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, tonyg
Project:
chromium
Visibility:
Public.

Description

Reland change to use a native MessagePump instead of a MessagePumpDefault. Original CL: https://codereview.chromium.org/331513002/ The previous CL caused a bunch of LibJingle unit tests to fail because the tests were using a gtest death test which runs in the context of a fork()ed but not execu()ed process. A CF Message loop can't live in this environment. Explicitly construct a MessagePumpDefault for these tests. BUG=356804, 385604 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279013

Patch Set 1 #

Patch Set 2 : Now with valgrind suppressions #

Patch Set 3 : Fix compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -41 lines) Patch
M base/message_loop/message_loop.cc View 2 chunks +9 lines, -1 line 0 comments Download
M base/message_loop/message_pump_default.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 26 chunks +48 lines, -39 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
jeremy
Reland change to use a native MessagePump instead of a MessagePumpDefault. The previous CL caused ...
6 years, 6 months ago (2014-06-13 23:13:11 UTC) #1
jeremy
ajwong: owner review for libjingle please.
6 years, 6 months ago (2014-06-13 23:22:23 UTC) #2
jeremy
6 years, 6 months ago (2014-06-13 23:22:42 UTC) #3
Mark Mentovai
LGTM in base.
6 years, 6 months ago (2014-06-13 23:39:15 UTC) #4
awong
LGTM
6 years, 6 months ago (2014-06-14 00:01:10 UTC) #5
jeremy
Valgrind wasn't happy with the patch, from an initial look the leaks it's reporting are ...
6 years, 6 months ago (2014-06-17 13:25:16 UTC) #6
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 6 months ago (2014-06-19 13:44:53 UTC) #7
jeremy
The CQ bit was unchecked by jeremy@chromium.org
6 years, 6 months ago (2014-06-19 13:45:14 UTC) #8
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 6 months ago (2014-06-19 13:46:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/331983002/20001
6 years, 6 months ago (2014-06-19 13:47:43 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 18:04:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/24437) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/36082)
6 years, 6 months ago (2014-06-19 18:04:59 UTC) #12
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 6 months ago (2014-06-22 11:48:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/331983002/20001
6 years, 6 months ago (2014-06-22 11:48:54 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-22 12:00:53 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-22 12:03:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/35096)
6 years, 6 months ago (2014-06-22 12:03:48 UTC) #17
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 6 months ago (2014-06-22 12:34:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/331983002/40001
6 years, 6 months ago (2014-06-22 12:35:31 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-22 14:25:01 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-22 14:42:29 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/165205)
6 years, 6 months ago (2014-06-22 14:42:29 UTC) #22
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 6 months ago (2014-06-22 16:15:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/331983002/40001
6 years, 6 months ago (2014-06-22 16:16:09 UTC) #24
commit-bot: I haz the power
Change committed as 279013
6 years, 6 months ago (2014-06-22 16:16:39 UTC) #25
ckocagil
6 years, 6 months ago (2014-06-22 20:55:34 UTC) #26
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/332333004/ by ckocagil@chromium.org.

The reason for reverting is: Breaks XmppConnectionTest.MultipleConnect on Mac:
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg....

Powered by Google App Engine
This is Rietveld 408576698