chrome/test/chromedriver/command_listener.cc - Issue 331943003: [ChromeDriver] Added CommandListener interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/command_listener.cc

Issue 331943003: [ChromeDriver] Added CommandListener interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "sync/engine/commit_contribution.h"	5 #include "chrome/test/chromedriver/command_listener.h"

	6 #include "chrome/test/chromedriver/chrome/status.h"

6	7

7 namespace syncer {	8 CommandListener::~CommandListener() {}

8	9

9 CommitContribution::CommitContribution() {}	10 Status CommandListener::OnCommand(const std::string& command_name) {
	stgao 2014/06/15 23:54:40 I think this default implementation file could be I think this default implementation file could be removed, if we don't create any instance of CommandListener. klm 2014/06/16 16:11:29 +1 -- pure virtual, just like other interfaces, e. Show quoted text On 2014/06/15 23:54:40, Shuotao wrote: > I think this default implementation file could be removed, if we don't create > any instance of CommandListener. +1 -- pure virtual, just like other interfaces, e.g. there is no web_view.cc. The virtual destructor body should be inline in the header.
10	11 return Status(kOk);

11 CommitContribution::~CommitContribution() {}	12 }

12

13 } // namespace syncer

OLD	NEW