Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 331913003: Tweak git gc settings, and periodically re-bootstrap. (Closed)

Created:
6 years, 6 months ago by szager1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix sorting of zip bundles. #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M git_cache.py View 2 3 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
szager1
6 years, 6 months ago (2014-06-13 18:52:31 UTC) #1
Ryan Tseng
lgtm https://codereview.chromium.org/331913003/diff/20001/git_cache.py File git_cache.py (right): https://codereview.chromium.org/331913003/diff/20001/git_cache.py#newcode274 git_cache.py:274: key=lambda x: x.split('/')[-1]) What was broken?
6 years, 6 months ago (2014-06-13 23:04:53 UTC) #2
szager1
https://codereview.chromium.org/331913003/diff/20001/git_cache.py File git_cache.py (right): https://codereview.chromium.org/331913003/diff/20001/git_cache.py#newcode274 git_cache.py:274: key=lambda x: x.split('/')[-1]) On 2014/06/13 23:04:53, Ryan T. wrote: ...
6 years, 6 months ago (2014-06-16 04:46:26 UTC) #3
szager1
The CQ bit was checked by szager@chromium.org
6 years, 6 months ago (2014-06-16 17:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/331913003/40001
6 years, 6 months ago (2014-06-16 17:12:07 UTC) #5
commit-bot: I haz the power
Change committed as 277473
6 years, 6 months ago (2014-06-16 17:13:52 UTC) #6
Ryan Tseng
6 years, 6 months ago (2014-06-16 17:28:22 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/331913003/diff/20001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/331913003/diff/20001/git_cache.py#newcode274
git_cache.py:274: key=lambda x: x.split('/')[-1])
On 2014/06/16 04:46:26, szager1 wrote:
> On 2014/06/13 23:04:53, Ryan T. wrote:
> > What was broken?
> 
> Whoops, nothing was broken.  I started thinking about how to handle this if
the
> base names use git hashes instead of svn revisions, but I didn't finish it. 
I'm
> going to revert this snippet, we can address the sorting issue separately.

Ah. fwiw the bootstrap zip file uses the git number, not the svn revision
number.  So by design this relies on the filename not being a git hash.

Powered by Google App Engine
This is Rietveld 408576698