src/hydrogen-instructions.h - Issue 331863015: Remove bogus assertions in HCompareObjectEqAndBranch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 331863015: Remove bogus assertions in HCompareObjectEqAndBranch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: test case Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index d691cbe08d3ac95e896b4fa18018792f65ef10cc..ef424252be0eb47c26ebd0a34fc694bbe1f3c263 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -4383,12 +4383,6 @@ class HCompareObjectEqAndBranch : public HTemplateControlInstruction<2, 2> {

HBasicBlock* true_target = NULL,

HBasicBlock* false_target = NULL)

: known_successor_index_(kNoKnownSuccessorIndex) {

- ASSERT(!left->IsConstant() ||

- (!HConstant::cast(left)->HasInteger32Value() ||

- HConstant::cast(left)->HasSmiValue()));

- ASSERT(!right->IsConstant() ||

- (!HConstant::cast(right)->HasInteger32Value() ||

- HConstant::cast(right)->HasSmiValue()));

SetOperandAt(0, left);

SetOperandAt(1, right);

SetSuccessorAt(0, true_target);