Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 331863014: Fix *-baseline computation for {text-,}after-edge/ideographic/baseline (Closed)

Created:
6 years, 6 months ago by fs
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Fix *-baseline computation for {text-,}after-edge/ideographic/baseline Negative descents were assumed, although they are positive. Fix sign of 'descent' in the {text-,}after-edge and ideographic cases. Also fix the obvious mistake in the 'baseline' case, where it ought to be handled in a similar way as 'auto', and not just return the "computed" alignment-baseline value. Added an additional case to pre-existing test for alignment-baseline. TEST=svg/custom/{alignment,dominant}-baseline-modes.svg (pre-existing) BUG=143990 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176877

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/alignment-baseline-modes.svg View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 6 months ago (2014-06-23 13:02:49 UTC) #1
Erik Dahlström (inactive)
Non-owner LGTM.
6 years, 6 months ago (2014-06-23 14:39:15 UTC) #2
pdr.
On 2014/06/23 14:39:15, Erik Dahlström wrote: > Non-owner LGTM. LGTM
6 years, 6 months ago (2014-06-24 21:26:30 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-24 21:26:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/331863014/20001
6 years, 6 months ago (2014-06-24 21:27:42 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 21:30:47 UTC) #6
Message was sent while issue was closed.
Change committed as 176877

Powered by Google App Engine
This is Rietveld 408576698