Issue 331863014: Fix *-baseline computation for {text-,}after-edge/ideographic/baseline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331863014: Fix *-baseline computation for {text-,}after-edge/ideographic/baseline (Closed)

Created:
6 years, 6 months ago by fs

Modified:
6 years, 6 months ago

Reviewers:
pdr., Erik Dahlström (inactive)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix *-baseline computation for {text-,}after-edge/ideographic/baseline Negative descents were assumed, although they are positive. Fix sign of 'descent' in the {text-,}after-edge and ideographic cases. Also fix the obvious mistake in the 'baseline' case, where it ought to be handled in a similar way as 'auto', and not just return the "computed" alignment-baseline value. Added an additional case to pre-existing test for alignment-baseline. TEST=svg/custom/{alignment,dominant}-baseline-modes.svg (pre-existing) BUG=143990 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176877

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/svg/custom/alignment-baseline-modes.svg	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pdr.

On 2014/06/23 14:39:15, Erik Dahlström wrote: > Non-owner LGTM. LGTM

6 years, 6 months ago (2014-06-24 21:26:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/331863014/20001

6 years, 6 months ago (2014-06-24 21:27:42 UTC) #5

Message was sent while issue was closed.

Change committed as 176877

Expand Messages | Collapse Messages