Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: sync/engine/get_commit_ids.h

Issue 331863010: sync: Remove support for hierarchy deletions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/engine/get_commit_ids.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/get_commit_ids.h
diff --git a/sync/engine/get_commit_ids.h b/sync/engine/get_commit_ids.h
index b435848e3495970b26b80530853a68b8d69a88af..ddbdb89e5ff6eb95803f2268bd48e78560997442 100644
--- a/sync/engine/get_commit_ids.h
+++ b/sync/engine/get_commit_ids.h
@@ -23,14 +23,11 @@ class BaseTransaction;
// specified |type| and are ready for commit.
//
// This function returns handles in "commit order". A valid commit ordering is
-// one where parents are placed before children, predecessors are placed before
-// successors, and deletes appear after creates and moves.
+// one where server-unknown items are committed parents-first, and deletions
+// are committed children-first.
//
-// The predecessor to successor rule was implemented when we tracked positions
-// within a folder that was sensitive to such things. The current positioning
-// system can handle receiving the elements within a folder out of order, so we
-// may be able to remove that functionality in the future.
-// See crbug.com/287938.
+// This function also enforces some position ordering constraints that are no
+// longer necessary. We should relax those constraints. See crbug.com/287938.
SYNC_EXPORT_PRIVATE void GetCommitIdsForType(
syncable::BaseTransaction* trans,
ModelType type,
« no previous file with comments | « no previous file | sync/engine/get_commit_ids.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698