Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: sync/engine/get_commit_ids.h

Issue 331863010: sync: Remove support for hierarchy deletions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sync/engine/get_commit_ids.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_ENGINE_GET_COMMIT_IDS_H_ 5 #ifndef SYNC_ENGINE_GET_COMMIT_IDS_H_
6 #define SYNC_ENGINE_GET_COMMIT_IDS_H_ 6 #define SYNC_ENGINE_GET_COMMIT_IDS_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "sync/base/sync_export.h" 10 #include "sync/base/sync_export.h"
11 #include "sync/internal_api/public/base/model_type.h" 11 #include "sync/internal_api/public/base/model_type.h"
12 #include "sync/syncable/directory.h" 12 #include "sync/syncable/directory.h"
13 13
14 using std::vector; 14 using std::vector;
15 15
16 namespace syncer { 16 namespace syncer {
17 17
18 namespace syncable { 18 namespace syncable {
19 class BaseTransaction; 19 class BaseTransaction;
20 } 20 }
21 21
22 // Returns up to |max_entries| metahandles of entries that belong to the 22 // Returns up to |max_entries| metahandles of entries that belong to the
23 // specified |type| and are ready for commit. 23 // specified |type| and are ready for commit.
24 // 24 //
25 // This function returns handles in "commit order". A valid commit ordering is 25 // This function returns handles in "commit order". A valid commit ordering is
26 // one where parents are placed before children, predecessors are placed before 26 // one where server-unknown items are committed parents-first, and deletions
27 // successors, and deletes appear after creates and moves. 27 // are committed children-first.
28 // 28 //
29 // The predecessor to successor rule was implemented when we tracked positions 29 // This function also enforces some position ordering constraints that are no
30 // within a folder that was sensitive to such things. The current positioning 30 // longer necessary. We should relax those constraints. See crbug.com/287938.
31 // system can handle receiving the elements within a folder out of order, so we
32 // may be able to remove that functionality in the future.
33 // See crbug.com/287938.
34 SYNC_EXPORT_PRIVATE void GetCommitIdsForType( 31 SYNC_EXPORT_PRIVATE void GetCommitIdsForType(
35 syncable::BaseTransaction* trans, 32 syncable::BaseTransaction* trans,
36 ModelType type, 33 ModelType type,
37 size_t max_entries, 34 size_t max_entries,
38 std::vector<int64>* out); 35 std::vector<int64>* out);
39 36
40 } // namespace syncer 37 } // namespace syncer
41 38
42 #endif // SYNC_ENGINE_GET_COMMIT_IDS_H_ 39 #endif // SYNC_ENGINE_GET_COMMIT_IDS_H_
OLDNEW
« no previous file with comments | « no previous file | sync/engine/get_commit_ids.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698