Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 331863004: Revert 276344 "Add callback in VideoDecoder and AudioDecoder to ..." (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert 276344 "Add callback in VideoDecoder and AudioDecoder to ..." Speculatively reverting ALL changes made between 37.0.2043 and 2044 to the media module to see if major regression disappears. Every change affecting this module will be reverted on branch only as an experiment over the weekend. > Add callback in VideoDecoder and AudioDecoder to return decoded frames. > > Previously decoded frames were returned using the DecodeCB callback, > which is called in response to Decode(). This didn't work very well, > particularly for GPU decoder, because decode buffers do not always map > to decoded frames 1 to 1. > > BUG=338529 > > Review URL: https://codereview.chromium.org/297553002 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+960 lines, -747 lines) Patch
M media/base/audio_decoder.h View 1 chunk +18 lines, -24 lines 0 comments Download
M media/base/audio_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +4 lines, -7 lines 0 comments Download
M media/base/video_decoder.h View 3 chunks +19 lines, -21 lines 0 comments Download
M media/base/video_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 12 chunks +15 lines, -20 lines 0 comments Download
M media/filters/audio_renderer_impl_unittest.cc View 15 chunks +69 lines, -39 lines 0 comments Download
M media/filters/decoder_selector.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/filters/decoder_selector.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M media/filters/decoder_stream.h View 3 chunks +4 lines, -8 lines 0 comments Download
M media/filters/decoder_stream.cc View 10 chunks +71 lines, -73 lines 0 comments Download
M media/filters/decoder_stream_traits.h View 2 chunks +2 lines, -6 lines 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M media/filters/decrypting_audio_decoder.h View 3 chunks +7 lines, -5 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 12 chunks +34 lines, -20 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 15 chunks +52 lines, -48 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 9 chunks +14 lines, -16 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 14 chunks +22 lines, -31 lines 0 comments Download
M media/filters/fake_video_decoder.h View 4 chunks +6 lines, -5 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 8 chunks +39 lines, -33 lines 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 14 chunks +46 lines, -57 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 4 chunks +7 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 7 chunks +42 lines, -14 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder_unittest.cc View 7 chunks +31 lines, -16 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 3 chunks +6 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 7 chunks +80 lines, -55 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 12 chunks +92 lines, -60 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 5 chunks +19 lines, -16 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 15 chunks +87 lines, -41 lines 0 comments Download
M media/filters/opus_audio_decoder.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/filters/opus_audio_decoder.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M media/filters/opus_audio_decoder_unittest.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 12 chunks +14 lines, -20 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 3 chunks +22 lines, -6 lines 0 comments Download
M media/filters/video_renderer_impl_unittest.cc View 12 chunks +83 lines, -38 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 2 chunks +1 line, -4 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-14 03:51:24 UTC) #1
amineer_google
Committed patchset #1 manually as r277176 (tree was closed).
6 years, 6 months ago (2014-06-14 03:53:09 UTC) #2
xhwang
On 2014/06/14 03:53:09, amineer wrote: > Committed patchset #1 manually as r277176 (tree was closed). ...
6 years, 6 months ago (2014-06-14 15:38:44 UTC) #3
chromium-reviews
6 years, 6 months ago (2014-06-14 16:53:38 UTC) #4
https://code.google.com/p/chromium/issues/detail?id=383715

I already talked to Sergey about this, and while his explanation of why his
change is unrelated made sense to me, we still have some major challenges
(the bug above shows fixed, but only because of a blacklist, and we now
have other issues cropping up as a result) in the code.  I was trying a
blanket revert of each and every media module change in the CL range but
unfortunately it failed compile.  I'll be working this more tomorrow /
Monday but any assistance you might be able to provide would be greatly
appreciated.


On Sat, Jun 14, 2014 at 8:38 AM, <xhwang@chromium.org> wrote:

> On 2014/06/14 03:53:09, amineer wrote:
>
>> Committed patchset #1 manually as r277176 (tree was closed).
>>
>
> Is there a bug tracking the regression you mentioned?
>
> https://codereview.chromium.org/331863004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698