Have NodeList::item() overrides return an Element* when appropriate

Have NodeList::item() overrides return an Element* when appropriate

Have NodeList::item() overrides return an Element* when appropriate instead
of a generic Node*. This makes it clear to callers that these are actually
returning Elements and avoids unnecessary isElementNode() checks or casts
that look unsafe.

R=adamk@chromium.org, esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176239

[adamk, 2014-06-16 20:29:18]

lgtm. Perhaps LiveNodeList and its subclasses should have "Element" in their
name instead of "Node"? I was surprised this worked until I reminded myself that
ChildNodeList subclasses NodeList, not LiveNodeList.

[Inactive, 2014-06-16 20:37:37]

On 2014/06/16 20:29:18, adamk wrote:
> lgtm. Perhaps LiveNodeList and its subclasses should have "Element" in their
> name instead of "Node"? I was surprised this worked until I reminded myself
that
> ChildNodeList subclasses NodeList, not LiveNodeList.

I think renaming them as you suggest would make sense indeed. I will propose
this in a follow-up.

[Inactive, 2014-06-16 20:37:40]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-16 20:38:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/331863003/1

[commit-bot: I haz the power, 2014-06-16 20:41:36]

Change committed as 176239