Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: remoting/host/remoting_me2me_host.cc

Issue 331853009: Add enable_vp9 option to host config. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/host_config.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/remoting_me2me_host.cc
diff --git a/remoting/host/remoting_me2me_host.cc b/remoting/host/remoting_me2me_host.cc
index eb54ab876cc7cd2e1919a1a4dafb8b78eec3db8d..857caf498f13c1fa8e52608a8deaf0dd5cf8e211 100644
--- a/remoting/host/remoting_me2me_host.cc
+++ b/remoting/host/remoting_me2me_host.cc
@@ -124,6 +124,9 @@ const char kAuthSocknameSwitchName[] = "ssh-auth-sockname";
// when it is successfully started.
const char kSignalParentSwitchName[] = "signal-parent";
+// Command line switch used to enable VP9 encoding.
+const char kEnableVp9SwitchName[] = "enable-vp9";
+
// Value used for --host-config option to indicate that the path must be read
// from stdin.
const char kStdinConfigPath[] = "-";
@@ -287,6 +290,7 @@ class HostProcess
std::string serialized_config_;
std::string host_owner_;
bool use_service_account_;
+ bool enable_vp9_;
scoped_ptr<policy_hack::PolicyWatcher> policy_watcher_;
std::string host_domain_;
@@ -331,6 +335,7 @@ HostProcess::HostProcess(scoped_ptr<ChromotingHostContext> context,
: context_(context.Pass()),
state_(HOST_INITIALIZING),
use_service_account_(false),
+ enable_vp9_(false),
host_username_match_required_(false),
allow_nat_traversal_(true),
allow_relay_(true),
@@ -816,6 +821,14 @@ bool HostProcess::ApplyConfig(scoped_ptr<JsonHostConfig> config) {
host_owner_ = xmpp_server_config_.username;
use_service_account_ = false;
}
+
+ // Allow offering of VP9 encoding to be overridden by the command-line.
+ if (CommandLine::ForCurrentProcess()->HasSwitch(kEnableVp9SwitchName)) {
+ enable_vp9_ = true;
+ } else {
+ config->GetBoolean(kEnableVp9ConfigPath, &enable_vp9_);
+ }
+
return true;
}
@@ -1190,6 +1203,13 @@ void HostProcess::StartHost() {
context_->network_task_runner(),
context_->ui_task_runner()));
+ if (enable_vp9_) {
+ scoped_ptr<protocol::CandidateSessionConfig> config =
+ host_->protocol_config()->Clone();
+ config->EnableVideoCodec(protocol::ChannelConfig::CODEC_VP9);
+ host_->set_protocol_config(config.Pass());
+ }
+
// TODO(simonmorris): Get the maximum session duration from a policy.
#if defined(OS_LINUX)
host_->SetMaximumSessionDuration(base::TimeDelta::FromHours(20));
« no previous file with comments | « remoting/host/host_config.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698