Issue 331853007: Reverting r176101 - "Crash test case:"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331853007: Reverting r176101 - "Crash test case:" (Closed)

Created:
6 years, 6 months ago by Dirk Pranke

Modified:
6 years, 6 months ago

Reviewers:
kostyatinskiy

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Reverting r176101 - "Crash test case:" The test now appears to time out periodically (i.e., it's not flaky). Reverting. Original description: > Crash test case: > 1. Open page with javascript > 2. Add breakpoint > 3. Stop on breakpoint > 4. Use live edit and save script > The test worked for Chromium revision until May 30. TBR=kostyatinskiy@google.com BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176131

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -36 lines)			Patch
	M	LayoutTests/inspector/sources/debugger/live-edit.html	View		2 chunks	+1 line, -32 lines	0 comments	Download
	M	LayoutTests/inspector/sources/debugger/live-edit-expected.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Original CL was here: https://codereview.chromium.org/329533002/ Here's some links to various timeouts: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=inspector/sources/debugger/live-edit.html

6 years, 6 months ago (2014-06-13 20:38:58 UTC) #1

Dirk Pranke

6 years, 6 months ago (2014-06-13 20:39:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r176131 (presubmit successful).

Expand Messages | Collapse Messages