Default to nicer font settings on SystemParametersInfo failure

Default to nicer font settings on SystemParametersInfo failure

SystemParametersInfo will fail if we've disconnected win32k
via the sandbox on Win8+. So, just default to nicer font
settings for now, since we know the OS supports them.

BUG=365160
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176134

[jschuh, 2014-06-13 19:07:51]

ptal

[jschuh, 2014-06-13 19:09:00]

On second though, jamesr@ would you mind reviewing? Should be a rubberstamp (I
think).

[jamesr, 2014-06-13 19:11:59]

Maybe eae could review?  I don't know what these bits do.

[jschuh, 2014-06-13 19:14:39]

On 2014/06/13 19:11:59, jamesr wrote:
> Maybe eae could review?  I don't know what these bits do.

That's fine. I was just blindly groping around for a reviewer.

[eae, 2014-06-13 19:35:31]

LGTM w/nit

https://codereview.chromium.org/331843004/diff/1/Source/platform/fonts/win/Fo...
File Source/platform/fonts/win/FontPlatformDataWin.cpp (right):

https://codereview.chromium.org/331843004/diff/1/Source/platform/fonts/win/Fo...
Source/platform/fonts/win/FontPlatformDataWin.cpp:107: gFlags =
SkPaint::kAntiAlias_Flag | SkPaint::kLCDRenderText_Flag;
Could you add a FIXME(eae) here to query the DW font settings instead? Some
users do turn off font smoothing and we want to respect that.

[jschuh, 2014-06-13 19:44:28]

ty sirs.

https://codereview.chromium.org/331843004/diff/1/Source/platform/fonts/win/Fo...
File Source/platform/fonts/win/FontPlatformDataWin.cpp (right):

https://codereview.chromium.org/331843004/diff/1/Source/platform/fonts/win/Fo...
Source/platform/fonts/win/FontPlatformDataWin.cpp:107: gFlags =
SkPaint::kAntiAlias_Flag | SkPaint::kLCDRenderText_Flag;
On 2014/06/13 19:35:31, eae wrote:
> Could you add a FIXME(eae) here to query the DW font settings instead? Some
> users do turn off font smoothing and we want to respect that.

Done. Although, I maybe we should pass this in as a setting at renderer startup.
So, feel free to bug me if that seems easier.

[jschuh, 2014-06-13 19:44:32]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2014-06-13 19:45:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jschuh@chromium.org/331843004/20001

[eae, 2014-06-13 20:05:32]

On 2014/06/13 19:44:28, Justin Schuh wrote:
> Done. Although, I maybe we should pass this in as a setting at renderer
startup.
> So, feel free to bug me if that seems easier.

Yeah, that seems reasonable. I don't really care either way as long as we check
it somewhere :)

[commit-bot: I haz the power, 2014-06-13 20:54:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-06-13 21:57:26]

Change committed as 176134