Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 331823002: Reland "Rename kIs64BitArch with kRequiresCodeRange." (Closed)

Created:
6 years, 6 months ago by haitao.feng
Modified:
6 years, 6 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland "Rename kIs64BitArch with kRequiresCodeRange." R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21837

Patch Set 1 #

Patch Set 2 : Only assert requested <= kMaximalCodeRangeSize when the port requires code range" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M include/v8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/api.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/globals.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
haitao.feng
Changed the code_range_size's type from int to size_t as Sven suggested.
6 years, 6 months ago (2014-06-13 05:57:35 UTC) #1
Sven Panne
Some try bots are not happy with this CL, see above...
6 years, 6 months ago (2014-06-13 07:10:03 UTC) #2
haitao.feng
Changed the assertion to ASSERT(!kRequiresCodeRange || requested <= kMaximalCodeRangeSize); I am glad I could access ...
6 years, 6 months ago (2014-06-13 07:56:08 UTC) #3
haitao.feng
An alternative is to run those test under V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 so that the code ...
6 years, 6 months ago (2014-06-13 07:59:10 UTC) #4
Sven Panne
LGTM (and the bots ;-), I'll land it for you.
6 years, 6 months ago (2014-06-13 10:40:37 UTC) #5
Sven Panne
6 years, 6 months ago (2014-06-13 11:06:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r21837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698