Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 331803006: Partial revert of r21901 (2nd attempt) (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Partial revert of r21901 (2nd attempt) Only disable runtime check for sse2 if __SSE2__ is not defined. This is required for the x87 port BUG=none LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/base/atomicops_internals_x86_gcc.h View 3 chunks +29 lines, -1 line 0 comments Download
M src/base/atomicops_internals_x86_gcc.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-23 13:26:03 UTC) #1
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-06-23 13:29:11 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-23 13:30:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698