Issue 331803005: Oilpan: move MediaKeyError to the heap.

Issue 331803005: Oilpan: move MediaKeyError to the heap. (Closed)

Created:
6 years, 6 months ago by sof

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, philipj_slow, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, watchdog-blink-watchlist_google.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: move MediaKeyError to the heap. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176742

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop explicit #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
M	Source/bindings/v8/Dictionary.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/Dictionary.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/MediaKeyError.h	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	Source/core/html/MediaKeyError.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/MediaKeyEvent.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/MediaKeyEvent.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/encryptedmedia/MediaKeySession.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/encryptedmedia/MediaKeySession.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/331803005/diff/1/Source/core/html/MediaKeyError.h File Source/core/html/MediaKeyError.h (right): https://codereview.chromium.org/331803005/diff/1/Source/core/html/MediaKeyError.h#newcode59 Source/core/html/MediaKeyError.h:59: explicit MediaKeyError(Code code, unsigned long systemCode) : m_code(code), ...

6 years, 6 months ago (2014-06-23 10:49:17 UTC) #2

sof

https://codereview.chromium.org/331803005/diff/1/Source/core/html/MediaKeyError.h File Source/core/html/MediaKeyError.h (right): https://codereview.chromium.org/331803005/diff/1/Source/core/html/MediaKeyError.h#newcode59 Source/core/html/MediaKeyError.h:59: explicit MediaKeyError(Code code, unsigned long systemCode) : m_code(code), m_systemCode(systemCode) ...

6 years, 6 months ago (2014-06-23 10:56:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/331803005/20001

6 years, 6 months ago (2014-06-23 10:57:36 UTC) #5

Message was sent while issue was closed.

Change committed as 176742

Expand Messages | Collapse Messages