Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 331803004: context.addHitRegion should return if the DOMException occurs. (Closed)

Created:
6 years, 6 months ago by zino
Modified:
6 years, 6 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

context.addHitRegion should return if the DOMException occurs. It may randomly make a crash or an unknown error. BUG=387561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
zino
I'm not sure that this CL is related to crbug.com/387561. Because I don't have the ...
6 years, 6 months ago (2014-06-23 09:35:18 UTC) #1
zino
On 2014/06/23 09:35:18, zino wrote: > I'm not sure that this CL is related to ...
6 years, 6 months ago (2014-06-23 09:37:05 UTC) #2
Justin Novosad
On 2014/06/23 09:37:05, zino wrote: > On 2014/06/23 09:35:18, zino wrote: > > I'm not ...
6 years, 6 months ago (2014-06-23 14:16:42 UTC) #3
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 6 months ago (2014-06-23 17:23:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/331803004/1
6 years, 6 months ago (2014-06-23 17:24:02 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-23 18:27:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 19:58:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13163)
6 years, 6 months ago (2014-06-23 19:58:27 UTC) #8
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 6 months ago (2014-06-23 23:55:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/331803004/1
6 years, 6 months ago (2014-06-23 23:56:25 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 23:57:12 UTC) #11
Message was sent while issue was closed.
Change committed as 176795

Powered by Google App Engine
This is Rietveld 408576698