Delete ASSERT_DISABLED

Delete ASSERT_DISABLED

ASSERT_ENABLED doens't have more not double negatives.

Note the #ifndef ASSERT_DISABLED in DatabaseThread.cpp was always compiled out
because ASSERT_DISABLED was always defined to be either 0 or 1.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176120

[abarth-chromium, 2014-06-13 06:28:52]

I can haz review+cq?

[haraken, 2014-06-13 06:33:55]

LGTM

https://codereview.chromium.org/331793004/diff/1/Source/modules/webdatabase/D...
File Source/modules/webdatabase/DatabaseThread.cpp (left):

https://codereview.chromium.org/331793004/diff/1/Source/modules/webdatabase/D...
Source/modules/webdatabase/DatabaseThread.cpp:151: MutexLocker
lock(m_terminationRequestedMutex);

I agree that this ASSERT is currently compiled out, but it looks like we need
this Mutex to access m_terminationRequested.

[abarth-chromium, 2014-06-13 06:36:46]

On 2014/06/13 at 06:33:55, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/331793004/diff/1/Source/modules/webdatabase/D...
> File Source/modules/webdatabase/DatabaseThread.cpp (left):
> 
>
https://codereview.chromium.org/331793004/diff/1/Source/modules/webdatabase/D...
> Source/modules/webdatabase/DatabaseThread.cpp:151: MutexLocker
lock(m_terminationRequestedMutex);
> 
> I agree that this ASSERT is currently compiled out, but it looks like we need
this Mutex to access m_terminationRequested.

It's suspicious to have a mutex that's only taken in debug builds.  Sounds like
a good way to have race conditions that exist in release but not in debug... 
webdatabase -> cry

[abarth-chromium, 2014-06-13 06:36:51]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-13 06:37:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/331793004/1

[haraken, 2014-06-13 06:46:25]

On 2014/06/13 06:36:46, abarth wrote:
> On 2014/06/13 at 06:33:55, haraken wrote:
> > LGTM
> > 
> >
>
https://codereview.chromium.org/331793004/diff/1/Source/modules/webdatabase/D...
> > File Source/modules/webdatabase/DatabaseThread.cpp (left):
> > 
> >
>
https://codereview.chromium.org/331793004/diff/1/Source/modules/webdatabase/D...
> > Source/modules/webdatabase/DatabaseThread.cpp:151: MutexLocker
> lock(m_terminationRequestedMutex);
> > 
> > I agree that this ASSERT is currently compiled out, but it looks like we
need
> this Mutex to access m_terminationRequested.
> 
> It's suspicious to have a mutex that's only taken in debug builds.  Sounds
like
> a good way to have race conditions that exist in release but not in debug... 
> webdatabase -> cry

I think that's just because we only have ASSERT(m_terminationRequested) in debug
builds.

[abarth-chromium, 2014-06-13 07:15:31]

On 2014/06/13 at 06:46:25, haraken wrote:
> I think that's just because we only have ASSERT(m_terminationRequested) in
debug builds.

Yes, but taking the lock create a synchronization point between the two threads
and can affect data races elsewhere in the code.  Races elsewhere that exist in
release builds might not exist in debug builds because of the extra
synchronization point.

[haraken, 2014-06-13 07:20:02]

On 2014/06/13 07:15:31, abarth wrote:
> On 2014/06/13 at 06:46:25, haraken wrote:
> > I think that's just because we only have ASSERT(m_terminationRequested) in
> debug builds.
> 
> Yes, but taking the lock create a synchronization point between the two
threads
> and can affect data races elsewhere in the code.  Races elsewhere that exist
in
> release builds might not exist in debug builds because of the extra
> synchronization point.

Makes sense.

[commit-bot: I haz the power, 2014-06-13 08:20:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-06-13 08:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 08:41:35]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[abarth-chromium, 2014-06-13 17:07:33]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-13 17:07:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/331793004/20001

[commit-bot: I haz the power, 2014-06-13 18:17:18]

Change committed as 176120