Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 331763002: HTML Imports: styles in removed imports should be applied when it comes back (Closed)

Created:
6 years, 6 months ago by Hajime Morrita
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+prerender_chromium.org, webcomponents-bugzilla_chromium.org
Project:
blink
Visibility:
Public.

Description

HTML Imports: styles in removed imports should be applied when it comes back Styles are un-applied when an import with the style is removed. The style however should be re-applied when the import is inserted back to the tree. BUG=381052 R=dglazkov@chromium.org TEST=import-readd* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -1 line) Patch
A LayoutTests/fast/html/imports/import-readd.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-dup-nested.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-dup-nested-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-dup-order.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-dup-order-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/fast/html/imports/import-readd-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/html/imports/import-readd-nested.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-nested-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-order-1.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-order-1-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-order-2.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/import-readd-order-2-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/style-blue.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/style-red.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/style-red-parent.html View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/LinkResource.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/imports/LinkImport.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
6 years, 6 months ago (2014-06-12 22:47:50 UTC) #1
dglazkov
lgtm
6 years, 6 months ago (2014-06-13 03:46:59 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 6 months ago (2014-06-13 16:35:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/331763002/1
6 years, 6 months ago (2014-06-13 16:36:38 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 16:39:51 UTC) #5
Message was sent while issue was closed. 
Change committed as 176117

Powered by Google App Engine
This is Rietveld 408576698