Always enable enhanced bookmarks external component extensions for incognito mode

chrome/browser/extensions/extension_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_util.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
+#include "base/sha1.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_sync_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
 #include "chrome/common/extensions/sync_helper.h"
 #include "content/public/browser/site_instance.h"
 #include "extensions/browser/extension_prefs.h"
@@ skipping 10 matching lines @@
 namespace extensions {
 namespace util {
 
 namespace {
 // The entry into the ExtensionPrefs for allowing an extension to script on
 // all urls without explicit permission.
 const char kExtensionAllowedOnAllUrlsPrefName[] =
     "extension_can_script_all_urls";
 }
 
+bool EnableIncognitoByDefault(const Extension* extension) {
+  // Internal component extensions are always enabled in IsIncognitoEnabled.
+  if (extension->location() != Manifest::EXTERNAL_COMPONENT)
+    return false;
+
+  // Enable external component extensions with hashes in this array in incognito
+  // mode.
+  static const char* kIncognitoEnabledExternalComponentExtensionHash[] = {
+    "D5736E4B5CF695CB93A2FB57E4FDC6E5AFAB6FE2", // http://crbug.com/312900
+    "D57DE394F36DC1C3220E7604C575D29C51A6C495", // http://crbug.com/319444
+    "3F65507A3B39259B38C8173C6FFA3D12DF64CCE9"  // http://crbug.com/371562
+  };
+
+  std::string hash = base::SHA1HashString(extension->id());
+  hash = base::HexEncode(hash.c_str(), hash.length());
+  for (size_t i = 0;
+       i < arraysize(kIncognitoEnabledExternalComponentExtensionHash); i++) {
+    if (hash == kIncognitoEnabledExternalComponentExtensionHash[i])
+      return true;
+  }

[not at google - send to devlin, 2014/06/18 23:49:20]

see code here:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

might help

[Mike Wittman, 2014/06/19 00:21:49]

Done.

+
+  return false;
+}
+
 bool IsIncognitoEnabled(const std::string& extension_id,
                         content::BrowserContext* context) {
   const Extension* extension = ExtensionRegistry::Get(context)->
       GetExtensionById(extension_id, ExtensionRegistry::ENABLED);
   if (extension) {
     if (!extension->can_be_incognito_enabled())
       return false;
     // If this is an existing component extension we always allow it to
     // work in incognito mode.
     if (extension->location() == Manifest::COMPONENT)
       return true;

[not at google - send to devlin, 2014/06/18 23:49:20]

like here:

if (IsWhitelistedForIncognito(..))
  return true;

is it because you want users to be able to turn *off* incognito mode later? that
doesn't seem necessary.

[Mike Wittman, 2014/06/19 00:21:49]

Either way works fine for my use case. I assumed the concern was over the cost
of checking the whitelist on every call to IsIncognitoEnabled.

   }
 
   return ExtensionPrefs::Get(context)->IsIncognitoEnabled(extension_id);
 }
 
 void SetIsIncognitoEnabled(const std::string& extension_id,
                            content::BrowserContext* context,
                            bool enabled) {
   ExtensionService* service =
       ExtensionSystem::Get(context)->extension_service();
@@ skipping 219 matching lines @@
       IDR_APP_DEFAULT_ICON);
 }
 
 const gfx::ImageSkia& GetDefaultExtensionIcon() {
   return *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
       IDR_EXTENSION_DEFAULT_ICON);
 }
 
 }  // namespace util
 }  // namespace extensions