Always enable enhanced bookmarks external component extensions for incognito mode

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
+#include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/component_loader.h"
@@ skipping 1960 matching lines @@
 
   bool unacknowledged_external = IsUnacknowledgedExternalExtension(extension);
 
   // Unpacked extensions default to allowing file access, but if that has been
   // overridden, don't reset the value.
   if (Manifest::ShouldAlwaysAllowFileAccess(extension->location()) &&
       !extension_prefs_->HasAllowFileAccessSetting(extension->id())) {
     extension_prefs_->SetAllowFileAccess(extension->id(), true);
   }
 
+  if (ShouldEnableForIncognito(extension))
+    extension_prefs_->SetIsIncognitoEnabled(extension->id(), true);
+
   AddExtension(extension);
 
   // If this is a new external extension that was disabled, alert the user
   // so he can reenable it. We do this last so that it has already been
   // added to our list of extensions.
   if (unacknowledged_external && !is_update) {
     UpdateExternalExtensionAlert();
     UMA_HISTOGRAM_ENUMERATION("Extensions.ExternalExtensionEvent",
                               EXTERNAL_EXTENSION_INSTALLED,
                               EXTERNAL_EXTENSION_BUCKET_BOUNDARY);
@@ skipping 526 matching lines @@
 
 void ExtensionService::AddUpdateObserver(extensions::UpdateObserver* observer) {
   update_observers_.AddObserver(observer);
 }
 
 void ExtensionService::RemoveUpdateObserver(
     extensions::UpdateObserver* observer) {
   update_observers_.RemoveObserver(observer);
 }
 
+bool ExtensionService::ShouldEnableForIncognito(
+    const extensions::Extension* extension) {
+  // NB: Component extensions are already always enabled via logic in
+  // extensions::util::IsIncognitoEnabled.
+  if (extension->location() != Manifest::EXTERNAL_COMPONENT)
+    return false;
+
+  // External component extensions with hashes in this array are always enabled
+  // in incognito mode.
+  static const char* kIncognitoEnabledExternalComponentExtensionHash[] = {
+    "D5736E4B5CF695CB93A2FB57E4FDC6E5AFAB6FE2", // http://crbug.com/312900
+    "D57DE394F36DC1C3220E7604C575D29C51A6C495", // http://crbug.com/319444
+    "3F65507A3B39259B38C8173C6FFA3D12DF64CCE9"  // http://crbug.com/371562

[not at google - send to devlin, 2014/06/18 00:42:02]

This code would be better contained in here, is where we whitelist component
extensions:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[Mike Wittman, 2014/06/18 03:17:50]

Moved the hashes and logic to extension_utils.{cc,h}.

+  };
+
+  std::string hash = base::SHA1HashString(extension->id());
+  hash = base::HexEncode(hash.c_str(), hash.length());
+  for (size_t i = 0;
+       i < arraysize(kIncognitoEnabledExternalComponentExtensionHash); i++) {
+    if (hash == kIncognitoEnabledExternalComponentExtensionHash[i])
+      return true;
+  }
+
+  return true;
+}
+
 // Used only by test code.
 void ExtensionService::UnloadAllExtensionsInternal() {
   profile_->GetExtensionSpecialStoragePolicy()->RevokeRightsForAllExtensions();
 
   registry_->ClearAll();
   system_->runtime_data()->ClearAll();
 
   // TODO(erikkay) should there be a notification for this?  We can't use
   // EXTENSION_UNLOADED since that implies that the extension has been disabled
   // or uninstalled.
 }
 
 void ExtensionService::OnProfileDestructionStarted() {
   ExtensionIdSet ids_to_unload = registry_->enabled_extensions().GetIDs();
   for (ExtensionIdSet::iterator it = ids_to_unload.begin();
        it != ids_to_unload.end();
        ++it) {
     UnloadExtension(*it, UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN);
   }
 }