Correctly deal with tokens for supervised users in ProfileOAuth2TokenService.

chrome/browser/signin/profile_oauth2_token_service.h

Index: chrome/browser/signin/profile_oauth2_token_service.h
diff --git a/chrome/browser/signin/profile_oauth2_token_service.h b/chrome/browser/signin/profile_oauth2_token_service.h
index 670adb6f622fd790989b097dac5aa9d512e49986..534ef9986c464eadf1e5cafa07d8bda36a5b8cd9 100644
--- a/chrome/browser/signin/profile_oauth2_token_service.h
+++ b/chrome/browser/signin/profile_oauth2_token_service.h
@@ -52,6 +52,11 @@ class ProfileOAuth2TokenService : public OAuth2TokenService,
   // Initializes this token service with the profile.
   virtual void Initialize(Profile* profile);
 
+  // Loads credentials from a backing persistent store to make them available
+  // after service is used between profile restarts.
+  // Usually it's not necessary to directly call this method.

[Andrew T Wilson (Slow), 2013/11/05 14:52:23]

Are we moving this back down to private: once PO2TS self-loads in Initialize()?

[Bernhard Bauer, 2013/11/05 16:26:51]

Yes, that was my plan. I added a TODO to that effect.

+  void LoadCredentials();
+
   // BrowserContextKeyedService implementation.
   virtual void Shutdown() OVERRIDE;
 
@@ -147,15 +152,13 @@ class ProfileOAuth2TokenService : public OAuth2TokenService,
   FRIEND_TEST_ALL_PREFIXES(ProfileOAuth2TokenServiceTest,
                            PersistenceLoadCredentials);
 
+  std::string GetAccountIdForMigratingRefreshToken();

[Andrew T Wilson (Slow), 2013/11/05 14:52:23]

Can you document this? It's not clear what this is.

[Bernhard Bauer, 2013/11/05 16:26:51]

Done.

+
   // WebDataServiceConsumer implementation:
   virtual void OnWebDataServiceRequestDone(
       WebDataServiceBase::Handle handle,
       const WDTypedResult* result) OVERRIDE;
 
-  // Loads credentials from a backing persistent store to make them available
-  // after service is used between profile restarts.
-  void LoadCredentials();
-
   // Loads credentials into in memory stucture.
   void LoadAllCredentialsIntoMemory(
       const std::map<std::string, std::string>& db_tokens);