gpu: Remove Create/DeleteImage IPC by adding an X11_PIXMAP_BUFFER GpuMemoryBuffer type.

content/browser/gpu/gpu_process_host.h

Index: content/browser/gpu/gpu_process_host.h
diff --git a/content/browser/gpu/gpu_process_host.h b/content/browser/gpu/gpu_process_host.h
index 079b549a597bf93024f3e52ca2ee6b923cf0251e..9be34bad42f4615fdb9b9c0b65478b88e6395238 100644
--- a/content/browser/gpu/gpu_process_host.h
+++ b/content/browser/gpu/gpu_process_host.h
@@ -65,7 +65,7 @@ class GpuProcessHost : public BrowserChildProcessHostDelegate,
 
   typedef base::Callback<void(bool)> CreateCommandBufferCallback;
 
-  typedef base::Callback<void(const gfx::Size)> CreateImageCallback;
+  typedef base::Callback<void(bool)> CreateImageCallback;
 
   typedef base::Callback<void(const gfx::GpuMemoryBufferHandle& handle)>
       CreateGpuMemoryBufferCallback;
@@ -122,9 +122,11 @@ class GpuProcessHost : public BrowserChildProcessHostDelegate,
       int route_id,
       const CreateCommandBufferCallback& callback);
 
-  // Tells the GPU process to create a new image using the given window.
+  // Tells the GPU process to create a new image using the given handle.
   void CreateImage(
-      gfx::PluginWindowHandle window,
+      const gfx::GpuMemoryBufferHandle& handle,
+      const gfx::Size& size,
+      unsigned internalformat,
       int client_id,

[alexst (slow to review), 2014/06/12 22:29:22]

I don't know that it's super important for this particular CL, but
GpuMemoryBufferHandle.global_id was meant to store a pair of <image_id,
client_id>. Maybe it makes sense to start using those here instead of also
adding them to all the functions.

[reveman, 2014/06/13 16:45:11]

We could use GpuMemoryBufferId::secondary_id instead but with all this code very
soon being removed I don't think it matters. I prefer to keep client_id for now
to keep things simple.

Fyi, the primary_id that's part of GpuMemoryBufferId is not an image id. It's a
gpu memory buffer id. The important difference is that the first is global and
an image id is specific to a command buffer. The image id is the result of
registering a gpu memory buffer with a specific command buffer and creating an
image object.

       int image_id,
       const CreateImageCallback& callback);
@@ -173,7 +175,7 @@ class GpuProcessHost : public BrowserChildProcessHostDelegate,
   void OnChannelEstablished(const IPC::ChannelHandle& channel_handle);
   void OnCommandBufferCreated(bool succeeded);
   void OnDestroyCommandBuffer(int32 surface_id);
-  void OnImageCreated(const gfx::Size size);
+  void OnImageCreated(bool succeeded);
   void OnGpuMemoryBufferCreated(const gfx::GpuMemoryBufferHandle& handle);
   void OnDidCreateOffscreenContext(const GURL& url);
   void OnDidLoseContext(bool offscreen,