gpu: Remove Create/DeleteImage IPC by adding an X11_PIXMAP_BUFFER GpuMemoryBuffer type.

ui/gfx/gpu_memory_buffer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_GPU_MEMORY_BUFFER_H_
 #define UI_GFX_GPU_MEMORY_BUFFER_H_
 
 #include "base/memory/shared_memory.h"
 #include "build/build_config.h"
 #include "ui/gfx/gfx_export.h"
 
-#if defined(OS_ANDROID)
-#include <third_party/khronos/EGL/egl.h>
+#if defined(USE_X11)
+#include "ui/gfx/x/x11_types.h"
 #endif
 
 namespace gfx {
 
 enum GpuMemoryBufferType {
   EMPTY_BUFFER,
   SHARED_MEMORY_BUFFER,
   IO_SURFACE_BUFFER,
   ANDROID_NATIVE_BUFFER,
   SURFACE_TEXTURE_BUFFER,
-  GPU_MEMORY_BUFFER_TYPE_LAST = SURFACE_TEXTURE_BUFFER
+  X11_PIXMAP_BUFFER,
+  GPU_MEMORY_BUFFER_TYPE_LAST = X11_PIXMAP_BUFFER
 };
 
 // TODO(alexst): Merge this with GpuMemoryBufferId as part of switchover to
 // the new API for GpuMemoryBuffer allocation when it's done.
 #if defined(OS_ANDROID)
 struct SurfaceTextureId {
   SurfaceTextureId() : primary_id(0), secondary_id(0) {}
   SurfaceTextureId(int32 primary_id, int32 secondary_id)
       : primary_id(primary_id), secondary_id(secondary_id) {}
   int32 primary_id;
@@ skipping 12 matching lines @@
 struct GFX_EXPORT GpuMemoryBufferHandle {
   GpuMemoryBufferHandle();
   bool is_null() const { return type == EMPTY_BUFFER; }
   GpuMemoryBufferType type;
   base::SharedMemoryHandle handle;
   GpuMemoryBufferId global_id;
 #if defined(OS_MACOSX)
   uint32 io_surface_id;
 #endif
 #if defined(OS_ANDROID)
-  EGLClientBuffer native_buffer;
+  long buffer_id;

[no sievers, 2014/07/11 18:33:29]

nit: why change this?

[reveman, 2014/07/11 21:08:06]

Everything in this struct is expected to be serialized and potentially used to
identify the buffer by another process. While "EGLClientBuffer" which is a
"void*" could be used as an identifier, that's pretty nasty. Long term we'll use
|global_id| (or |handle| if we add more generic gralloc support that works in
out of process mode) and the factory will do a lookup just like the X11Pixmap
factory does. I think buffer_id is fine for now and a big improvement over
EGLClientBuffer.

   SurfaceTextureId surface_texture_id;
 #endif
+#if defined(USE_X11)
+  XID pixmap;
+#endif
 };
 
 // This interface typically correspond to a type of shared memory that is also
 // shared with the GPU. A GPU memory buffer can be written to directly by
 // regular CPU code, but can also be read by the GPU.
 class GFX_EXPORT GpuMemoryBuffer {
  public:
   GpuMemoryBuffer();
   virtual ~GpuMemoryBuffer();
 
@@ skipping 13 matching lines @@
   // Returns the stride in bytes for the buffer.
   virtual uint32 GetStride() const = 0;
 
   // Returns a platform specific handle for this buffer.
   virtual GpuMemoryBufferHandle GetHandle() const = 0;
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_GPU_MEMORY_BUFFER_H_