Issue 331713004: Updated baselines for r176651 and r176666.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331713004: Updated baselines for r176651 and r176666. (Closed)

Created:
6 years, 6 months ago by Stephen White

Modified:
6 years, 5 months ago

Reviewers:
michaeln, jamesr, Xianzhu

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Updated baselines for r176651 and r176666. TBR=wangxianzhu@chromium.org,michaeln@chromium.org,jamesr@chromium.org BUG=381221, 371671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176686

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-1 lines, -25 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	LayoutTests/platform/android/compositing/contents-opaque/layer-transform-expected.txt	View	1 chunk	+0 lines, -25 lines	0 comments	Download
A +	LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/platform/win-xp/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/platform/win/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Committed patchset #1 manually as r176686 (tree was closed).

6 years, 6 months ago (2014-06-21 19:26:05 UTC) #1

michaeln

I'm just noticing change. What about r176666 caused an expectation change? It wasn't the intent ...

6 years, 5 months ago (2014-07-08 00:01:59 UTC) #2

Stephen White

6 years, 5 months ago (2014-07-08 00:10:52 UTC) #3

Message was sent while issue was closed.

On 2014/07/08 00:01:59, michaeln wrote:
> I'm just noticing change. What about r176666 caused an expectation change? It
> wasn't the intent of that CL to change the current behavior of any tests?

To be honest, I can't remember. It was during my gardening shift a week ago. It
may have been only r176651 that affected tests.

Expand Messages | Collapse Messages