Remove specialized access checks and overwrites altogether. They are already handled by GetOwnPrope…

Remove specialized access checks and overwrites altogether. They are already handled by GetOwnPropertyAttributes (and GetPropertyAttributesWithFailedAccessChecks)

BUG=
R=dcarney@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21922

[Toon Verwaest, 2014-06-16 17:09:00]

PTAL. On closer inspection, we don't need any of this code anymore.

I changed to code to rely on the LookupIterator to match the value found for the
PropertyAttributes with the actual accessor-pair that's loaded. Otherwise there
might be an all_can_read AccessorInfo behind (in hidden chain) a non-readable
AccessorPair, leaking the AccessorPair.

[Toon Verwaest, 2014-06-16 17:26:14]

https://codereview.chromium.org/331693006/diff/40001/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/331693006/diff/40001/src/runtime.cc#newcode1952
src/runtime.cc:1952: ASSIGN_RETURN_ON_EXCEPTION(
I'd avoid rewalking by using the LookupIterator, but for now we have tests that
actually check that ACCESS_GET is called here to explicitly not fetch the value
even though ACCESS_HAS above succeeded. I'll clean that up in a later phase.

[Toon Verwaest, 2014-06-16 18:23:21]

I removed the part of the test anyway. It was necessary to ensure it's also
correct in the value case, just like the accessors case.

The test was even more bogus than expected. It only returned a property
descriptor without calling the blocked getter because the
ReportFailedAccessCheck for GetProperty didn't throw an exception, and instead
just continued (returning undefined).

[dcarney, 2014-06-23 09:03:15]

lgtm

[Toon Verwaest, 2014-06-23 09:11:54]

Committed patchset #6 manually as r21922 (presubmit successful).