Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 331693004: Issue repaints when offsetFromRenderer changes for any squashed layer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed tests. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
index 6ef931465ca5ec2478a3b9b03b3f81c2d50b8031..71109e9fbbf2689405343fc72601d8909a7e7424 100644
--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -577,7 +577,13 @@ void CompositedLayerMapping::updateSquashingLayerGeometry(const LayoutPoint& off
for (size_t i = 0; i < layers.size(); ++i) {
LayoutPoint offsetFromTransformedAncestorForSquashedLayer = layers[i].renderLayer->computeOffsetFromTransformedAncestor();
LayoutSize offsetFromSquashLayerOrigin = (offsetFromTransformedAncestorForSquashedLayer - referenceOffsetFromTransformedAncestor) - squashLayerOriginInOwningLayerSpace;
- layers[i].offsetFromRenderer = -flooredIntSize(offsetFromSquashLayerOrigin);
+
+ // It is ok to repaint here, because all of the geometry needed to correctly repaint is computed by this point.
+ IntSize newOffsetFromRenderer = -flooredIntSize(offsetFromSquashLayerOrigin);
+ if (layers[i].offsetFromRendererSet && layers[i].offsetFromRenderer != newOffsetFromRenderer)
+ layers[i].renderLayer->repainter().repaintIncludingNonCompositingDescendants();
+ layers[i].offsetFromRenderer = newOffsetFromRenderer;
+ layers[i].offsetFromRendererSet = true;
layers[i].renderLayer->setSubpixelAccumulation(offsetFromSquashLayerOrigin.fraction());
ASSERT(layers[i].renderLayer->subpixelAccumulation() ==
@@ -586,7 +592,6 @@ void CompositedLayerMapping::updateSquashingLayerGeometry(const LayoutPoint& off
// FIXME: find a better design to avoid this redundant value - most likely it will make
// sense to move the paint task info into RenderLayer's m_compositingProperties.
layers[i].renderLayer->setOffsetFromSquashingLayerOrigin(layers[i].offsetFromRenderer);
-
}
for (size_t i = 0; i < layers.size(); ++i)

Powered by Google App Engine
This is Rietveld 408576698