Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 331683005: Disable excluding of tested apk's code in test apks (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
aberent
CC:
chromium-reviews
Visibility:
Public.

Description

The new way of building test APKs loses some necessary classes from them, hence causing them to fail with "Class not found" errors. Disable this until we have a fix. BUG=384537, 272790 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277756

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/java_apk.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aberent
lgtm
6 years, 6 months ago (2014-06-17 10:44:59 UTC) #1
aberent
The CQ bit was checked by aberent@chromium.org
6 years, 6 months ago (2014-06-17 10:45:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/331683005/20001
6 years, 6 months ago (2014-06-17 10:46:35 UTC) #3
commit-bot: I haz the power
Change committed as 277756
6 years, 6 months ago (2014-06-17 14:42:45 UTC) #4
Peter Beverloo
Please reply to this CL with the relevant bug, and further relevant information for making ...
6 years, 6 months ago (2014-06-17 14:52:28 UTC) #5
cjhopman
On 2014/06/17 14:52:28, Peter Beverloo wrote: > Please reply to this CL with the relevant ...
6 years, 6 months ago (2014-06-17 16:45:12 UTC) #6
Peter Beverloo
On 2014/06/17 16:45:12, cjhopman wrote: > On 2014/06/17 14:52:28, Peter Beverloo wrote: > > Please ...
6 years, 6 months ago (2014-06-17 17:51:56 UTC) #7
Yusuf
6 years, 6 months ago (2014-06-18 17:49:50 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/341973002/ by yusufo@chromium.org.

The reason for reverting is: We are hitting the issue in
https://code.google.com/p/chromium/issues/detail?id=272790 again. So we will
have to reenable this fix.

The failing tests are being handled in separate CLs I believe..

Powered by Google App Engine
This is Rietveld 408576698